Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified search][Dashboard] truncate filter pills to 10 lines #170941

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Nov 9, 2023

Summary

Solves 1/3 of #170398

After assessing with @teresaalvarezsoler we decided to wrap to 10 lines and autoexpand.

(Ignore the missing 'x' in some filter pills, it was not impacted 🙏🏼 )

Screenshot 2023-11-10 at 11 20 32 Screenshot 2023-11-10 at 11 20 08 Screenshot 2023-11-10 at 11 19 58

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@mbondyra mbondyra added Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens Feature:Unified search Unified search related tasks v8.12.0 labels Nov 9, 2023
@mbondyra mbondyra force-pushed the lens/filters_truncation_multiline branch 2 times, most recently from 343b7f9 to 9ee1618 Compare November 9, 2023 13:03
@mbondyra mbondyra changed the title [Unified search] truncate filter pills [Unified search] truncate filter pills to 3 lines Nov 9, 2023
@mbondyra mbondyra changed the title [Unified search] truncate filter pills to 3 lines [Unified search][Dashboard] truncate filter pills to 3 lines Nov 9, 2023
@mbondyra mbondyra marked this pull request as ready for review November 9, 2023 15:18
@mbondyra mbondyra requested a review from a team as a code owner November 9, 2023 15:18
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@mbondyra mbondyra added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Nov 9, 2023
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@mbondyra mbondyra force-pushed the lens/filters_truncation_multiline branch from 9ee1618 to ae24193 Compare November 10, 2023 09:29
@mbondyra mbondyra requested a review from a team as a code owner November 10, 2023 10:26
@mbondyra mbondyra changed the title [Unified search][Dashboard] truncate filter pills to 3 lines [Unified search][Dashboard] truncate filter pills to 10 lines Nov 10, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 375.6KB 375.6KB +26.0B
unifiedSearch 215.5KB 215.6KB +126.0B
total +152.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM!

@mbondyra mbondyra merged commit 84e0da6 into elastic:main Nov 13, 2023
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 13, 2023
@mbondyra mbondyra deleted the lens/filters_truncation_multiline branch November 13, 2023 08:55
jillguyonnet pushed a commit to jillguyonnet/kibana that referenced this pull request Nov 16, 2023
…c#170941)

## Summary

Solves 1/3 of elastic#170398 

After assessing with @teresaalvarezsoler we decided to wrap to 10 lines
and autoexpand.

(Ignore the missing 'x' in some filter pills, it was not impacted 🙏🏼 ) 

<img width="1479" alt="Screenshot 2023-11-10 at 11 20 32"
src="https://github.com/elastic/kibana/assets/4283304/11da80df-92e2-4ea7-9efe-5e352bb95add">
<img width="396" alt="Screenshot 2023-11-10 at 11 20 08"
src="https://github.com/elastic/kibana/assets/4283304/0b37f2c1-d736-4507-ae12-0f3f0a3b11f5">
<img width="980" alt="Screenshot 2023-11-10 at 11 19 58"
src="https://github.com/elastic/kibana/assets/4283304/07dc61f6-92fa-4569-b5ee-011a9078006a">



### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features Feature:Lens Feature:Unified search Unified search related tasks impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants