[Custom threshold rule] Change title to Beta and remove/deprecate feature flag #171406
Assignees
Labels
Team:obs-ux-management
Observability Management User Experience Team
Comments
maryam-saeidi
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
As discussed with @maryam-saeidi the priority is to change the title from Technical Preview to Beta. The feature flag enabling Custom Threshold is defaulted to on, so there's less concern or problem if that needs to happen in a separate / follow up PR. |
maryam-saeidi
added a commit
that referenced
this issue
Dec 4, 2023
Part of #171406 ## Summary This PR changes the Custom threshold title from `Technical Preview` to `Beta`. <img src="https://github.com/elastic/kibana/assets/12370520/8a84ad54-b5f8-4989-a02d-5ab9c861945f" width=500 /> |Before|After| |---|---| |||
benakansara
added a commit
that referenced
this issue
Dec 7, 2023
Resolves #171406 - Deprecates following feature flag used for enabling/disabling Custom threshold rule: ``` xpack.observability.unsafe.thresholdRule.enabled ``` - Removes usage of this flag from code. - Adding this flag in `kibana.yml` will generate following warning: ``` [WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.thresholdRule.enabled". ``` --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 7, 2023
Resolves elastic#171406 - Deprecates following feature flag used for enabling/disabling Custom threshold rule: ``` xpack.observability.unsafe.thresholdRule.enabled ``` - Removes usage of this flag from code. - Adding this flag in `kibana.yml` will generate following warning: ``` [WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.thresholdRule.enabled". ``` --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 16f09fd)
kibanamachine
referenced
this issue
Dec 7, 2023
…72792) # Backport This will backport the following commits from `main` to `8.12`: - [Deprecate feature flag for Custom threshold rule (#172584)](#172584) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-07T09:34:11Z","message":"Deprecate feature flag for Custom threshold rule (#172584)\n\nResolves https://github.com/elastic/kibana/issues/171406\r\n\r\n- Deprecates following feature flag used for enabling/disabling Custom\r\nthreshold rule:\r\n```\r\nxpack.observability.unsafe.thresholdRule.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.thresholdRule.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"16f09fdcc45a2df9a3a7868ea9590227627b82ad","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172584,"url":"https://github.com/elastic/kibana/pull/172584","mergeCommit":{"message":"Deprecate feature flag for Custom threshold rule (#172584)\n\nResolves https://github.com/elastic/kibana/issues/171406\r\n\r\n- Deprecates following feature flag used for enabling/disabling Custom\r\nthreshold rule:\r\n```\r\nxpack.observability.unsafe.thresholdRule.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.thresholdRule.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"16f09fdcc45a2df9a3a7868ea9590227627b82ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172584","number":172584,"mergeCommit":{"message":"Deprecate feature flag for Custom threshold rule (#172584)\n\nResolves https://github.com/elastic/kibana/issues/171406\r\n\r\n- Deprecates following feature flag used for enabling/disabling Custom\r\nthreshold rule:\r\n```\r\nxpack.observability.unsafe.thresholdRule.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.thresholdRule.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"16f09fdcc45a2df9a3a7868ea9590227627b82ad"}}]}] BACKPORT--> Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🍒 Summary
When the custom threshold rule is ready as Beta, we need to change the title from Technical Preview to Beta and remove/deprecate the related feature flag.
🎯 Acceptance Criteria
The text was updated successfully, but these errors were encountered: