Deprecate feature flag for Custom threshold rule #172584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
benakansara
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
ersin-erdal
approved these changes
Dec 6, 2023
maryam-saeidi
approved these changes
Dec 6, 2023
|
@benakansara I see these instances in the code: (from what I see you only removed one of them)
|
For the first line, same reason as #172554 (comment) I didn't remove instances from serverless tests, as I wasn't sure about how to deprecate/remove existing feature flag from there. |
|
@maryam-saeidi I have removed feature flag usages from serverless tests. |
|
/oblt-deploy-serverless |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @benakansara |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2023
Resolves elastic#171406 - Deprecates following feature flag used for enabling/disabling Custom threshold rule: ``` xpack.observability.unsafe.thresholdRule.enabled ``` - Removes usage of this flag from code. - Adding this flag in `kibana.yml` will generate following warning: ``` [WARN ][config.deprecation] You no longer need to configure "xpack.observability.unsafe.thresholdRule.enabled". ``` --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 16f09fd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2023
…72792) # Backport This will backport the following commits from `main` to `8.12`: - [Deprecate feature flag for Custom threshold rule (#172584)](#172584) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Bena Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-07T09:34:11Z","message":"Deprecate feature flag for Custom threshold rule (#172584)\n\nResolves https://github.com/elastic/kibana/issues/171406\r\n\r\n- Deprecates following feature flag used for enabling/disabling Custom\r\nthreshold rule:\r\n```\r\nxpack.observability.unsafe.thresholdRule.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.thresholdRule.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"16f09fdcc45a2df9a3a7868ea9590227627b82ad","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172584,"url":"https://github.com/elastic/kibana/pull/172584","mergeCommit":{"message":"Deprecate feature flag for Custom threshold rule (#172584)\n\nResolves https://github.com/elastic/kibana/issues/171406\r\n\r\n- Deprecates following feature flag used for enabling/disabling Custom\r\nthreshold rule:\r\n```\r\nxpack.observability.unsafe.thresholdRule.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.thresholdRule.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"16f09fdcc45a2df9a3a7868ea9590227627b82ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172584","number":172584,"mergeCommit":{"message":"Deprecate feature flag for Custom threshold rule (#172584)\n\nResolves https://github.com/elastic/kibana/issues/171406\r\n\r\n- Deprecates following feature flag used for enabling/disabling Custom\r\nthreshold rule:\r\n```\r\nxpack.observability.unsafe.thresholdRule.enabled\r\n```\r\n- Removes usage of this flag from code.\r\n- Adding this flag in `kibana.yml` will generate following warning:\r\n```\r\n[WARN ][config.deprecation] You no longer need to configure \"xpack.observability.unsafe.thresholdRule.enabled\".\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"16f09fdcc45a2df9a3a7868ea9590227627b82ad"}}]}] BACKPORT--> Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #171406
kibana.ymlwill generate following warning: