-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard Navigation] GA Links Panel #172075
Labels
epic
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Project:Dashboard Navigation
Related to the Dashboard Navigation Project
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Comments
Heenawter
added
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
loe:small
Small Level of Effort
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Project:Dashboard Navigation
Related to the Dashboard Navigation Project
8.13 candidate
labels
Nov 28, 2023
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
added
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
and removed
8.13 candidate
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
labels
Jan 9, 2024
4 tasks
Heenawter
added a commit
that referenced
this issue
Mar 25, 2024
Closes #172075 Closes #178396 ## Summary In order to move the links panel into general availability, this PR does four main things: 1. It changes the default of the "Save to library" toggle in the flyout from `true` to `false` - this is in response to some early telemetry, which suggests that link panels **not** saved to the library are more common. | Before | After | |--------|--------| | ![Screenshot 2024-03-20 at 9 38 41 AM](https://github.com/elastic/kibana/assets/8698078/af42e570-98c2-4cbb-852f-0a34a7dd779b) | ![Screenshot 2024-03-20 at 9 36 10 AM](https://github.com/elastic/kibana/assets/8698078/2943e3fe-c3ce-4b23-a8cf-bba990995457) | 2. It fixes a styling issue in Serverless where the height of the secondary edit/add link flyout was incorrect. | Before | After | |--------|--------| | ![image](https://github.com/elastic/kibana/assets/8698078/0d32bda7-a5bc-4655-80ac-bffab6fce61a) | ![image](https://github.com/elastic/kibana/assets/8698078/78f32642-550b-475f-bbf1-12a38189592e) | 3. It removes the lab setting for the links panel. The removal of this setting is **not** a breaking change - it is completely safe to remove this setting **regardless** of the previous value. Telemetry tracking for this setting is also no longer required. | Before | After | |--------|--------| | ![Screenshot 2024-03-19 at 3 00 39 PM](https://github.com/elastic/kibana/assets/8698078/e9d5c19e-9ebd-4561-8391-4bb7e6f915d9) | ![image](https://github.com/elastic/kibana/assets/8698078/1325c0d0-349f-4dc9-897a-41049efb4670) | 4. It removes any reference to "Technical preview" or "Experimental" | Before | After | |--------|--------| | ![Screenshot 2024-03-19 at 2 55 20 PM](https://github.com/elastic/kibana/assets/8698078/2a246688-78b1-4376-9218-8b6b2a87dfed) | ![image](https://github.com/elastic/kibana/assets/8698078/20bf7b6c-ef85-4ede-851d-035fd9f53bbd) | | ![Screenshot 2024-03-19 at 2 56 14 PM](https://github.com/elastic/kibana/assets/8698078/c9fe5224-56d8-4d04-8b3c-f7c8b5433115) | ![Screenshot 2024-03-19 at 2 58 27 PM](https://github.com/elastic/kibana/assets/8698078/a2dfcb4d-2d42-40d0-a7d4-616587e69044) | ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
epic
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Project:Dashboard Navigation
Related to the Dashboard Navigation Project
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
Describe the feature:
Now that Phase 1 of the Links panel is wrapped up, it no longer needs to be marked as "Technical Preview" - time to GA this new feature! This should be a fairly straightforward change, which mostly means (1) addressing any feedback (if any) that has come up from the Links panel being available for two minors and (2) removing the "Technical preview" label/stage wherever it appears.
As part of this, we should also change the "Save to library" toggle to false by default, based on the current telemetry results.
The text was updated successfully, but these errors were encountered: