Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless observability] [Dashboard] Add link panel has two close buttons #178396

Closed
bhavyarm opened this issue Mar 11, 2024 · 1 comment · Fixed by #178999
Closed

[Serverless observability] [Dashboard] Add link panel has two close buttons #178396

bhavyarm opened this issue Mar 11, 2024 · 1 comment · Fixed by #178999
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

Kibana version: Serverless observability project on main

Browser version: chrome latest

Describe the bug: Dashboard-> add link panel has two close buttons.

Steps to reproduce:

  1. Install sample data
  2. Go to your favourite sample data dashboard
  3. Click edit -> add panel-> links panel -> add link
  4. Links panel has two close buttons

Doesn't happen in 8.13.0 BC

Screenshots (if relevant):

Screenshot 2024-03-11 at 10 53 16 AM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Mar 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter self-assigned this Mar 13, 2024
Heenawter added a commit that referenced this issue Mar 25, 2024
Closes #172075
Closes #178396

## Summary

In order to move the links panel into general availability, this PR does
four main things:
1. It changes the default of the "Save to library" toggle in the flyout
from `true` to `false` - this is in response to some early telemetry,
which suggests that link panels **not** saved to the library are more
common.

    | Before | After |
    |--------|--------|
| ![Screenshot 2024-03-20 at 9 38
41 AM](https://github.com/elastic/kibana/assets/8698078/af42e570-98c2-4cbb-852f-0a34a7dd779b)
| ![Screenshot 2024-03-20 at 9 36
10 AM](https://github.com/elastic/kibana/assets/8698078/2943e3fe-c3ce-4b23-a8cf-bba990995457)
|

2. It fixes a styling issue in Serverless where the height of the
secondary edit/add link flyout was incorrect.

    | Before | After |
    |--------|--------|
|
![image](https://github.com/elastic/kibana/assets/8698078/0d32bda7-a5bc-4655-80ac-bffab6fce61a)
|
![image](https://github.com/elastic/kibana/assets/8698078/78f32642-550b-475f-bbf1-12a38189592e)
|

3. It removes the lab setting for the links panel. The removal of this
setting is **not** a breaking change - it is completely safe to remove
this setting **regardless** of the previous value. Telemetry tracking
for this setting is also no longer required.

    | Before | After |
    |--------|--------|
| ![Screenshot 2024-03-19 at 3 00
39 PM](https://github.com/elastic/kibana/assets/8698078/e9d5c19e-9ebd-4561-8391-4bb7e6f915d9)
|
![image](https://github.com/elastic/kibana/assets/8698078/1325c0d0-349f-4dc9-897a-41049efb4670)
|


4. It removes any reference to "Technical preview" or "Experimental"
    
    | Before | After |
    |--------|--------|
| ![Screenshot 2024-03-19 at 2 55
20 PM](https://github.com/elastic/kibana/assets/8698078/2a246688-78b1-4376-9218-8b6b2a87dfed)
|
![image](https://github.com/elastic/kibana/assets/8698078/20bf7b6c-ef85-4ede-851d-035fd9f53bbd)
|
| ![Screenshot 2024-03-19 at 2 56
14 PM](https://github.com/elastic/kibana/assets/8698078/c9fe5224-56d8-4d04-8b3c-f7c8b5433115)
| ![Screenshot 2024-03-19 at 2 58
27 PM](https://github.com/elastic/kibana/assets/8698078/a2dfcb4d-2d42-40d0-a7d4-616587e69044)
|


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants