Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing ES Promotion: Ingest Node Pipelines Pipelines Delete should return an error for any pipelines not sucessfully deleted #73170

Closed
jbudz opened this issue Jul 23, 2020 · 5 comments
Assignees
Labels
blocker Feature:Ingest Node Pipelines Ingest node pipelines management skipped-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.0

Comments

@jbudz
Copy link
Member

jbudz commented Jul 23, 2020

CI Error

How to run against the new snapshot. I'll update if/when this isn't required - we'll promote if the skip gives a green build next.

{ Error: expected { itemsDeleted: [],
  errors: 
   [ { name: 'test_delete_pipeline_1', error: [Object] },
     { name: 'pipeline_does_not_exist', error: [Object] } ] } to sort of equal { itemsDeleted: [ 'test_delete_pipeline_1' ],
  errors: [ { name: 'pipeline_does_not_exist', error: [Object] } ] }
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/api_integration/apis/management/ingest_pipelines/ingest_pipelines.ts:295:25

looks limited to a formatting change via from elastic/elasticsearch#58207. one moment on shas for skipped tests

@jbudz jbudz added blocker skipped-test v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 23, 2020
jbudz added a commit that referenced this issue Jul 23, 2020
JSON formatting appears to have changed modestly. Tracking at #73170.
jbudz added a commit that referenced this issue Jul 23, 2020
JSON formatting appears to have changed modestly. Tracking at #73170.
jbudz added a commit that referenced this issue Jul 23, 2020
JSON formatting appears to have changed modestly. Tracking at #73170.
@jbudz
Copy link
Member Author

jbudz commented Jul 23, 2020

main: 8021616
7.x: 4bc149e
7.9: 32b6244

@jen-huang jen-huang added Team:Fleet Team label for Observability Data Collection Fleet team and removed Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@cjcenizal cjcenizal added Feature:Ingest Node Pipelines Ingest node pipelines management Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor

@alisonelizabeth Could you check this one out please? I suspect we just need to await calls to createPipeline, otherwise it seems like we'd end up with a race condition, which would explain the failure here. Though I could have expected a race condition to yield flaky test results sooner. 🤔

@alisonelizabeth
Copy link
Contributor

I'm not able to reproduce the failure. The ES PR referenced is related to the simulate API and doesn't appear to affect the creation/deletion of a pipeline. I just merged #73289, which should make the tests more robust. I'm going to close this issue for now, but feel free to open if the issue resurfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Ingest Node Pipelines Ingest node pipelines management skipped-test Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.9.0
Projects
None yet
Development

No branches or pull requests

5 participants