Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest pipelines] Make api tests more robust #73289

Merged
merged 1 commit into from
Jul 27, 2020
Merged

[Ingest pipelines] Make api tests more robust #73289

merged 1 commit into from
Jul 27, 2020

Conversation

alisonelizabeth
Copy link
Contributor

Related to #73170

This PR unskips the ingest node pipelines API integration tests and makes the tests themselves more robust when handling the setup/cleanup.

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 27, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth marked this pull request as ready for review July 27, 2020 16:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal
cjcenizal approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thanks for making these improvements, Alison!

@alisonelizabeth alisonelizabeth merged commit 7c24a61 into elastic:master Jul 27, 2020
@alisonelizabeth alisonelizabeth deleted the api_tests/ingest_pipelines branch July 27, 2020 19:19
@alisonelizabeth alisonelizabeth mentioned this pull request Jul 27, 2020
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jul 27, 2020
@alisonelizabeth
Make ingest node pipelines api tests more robust (elastic#73289)
bc21da3
@alisonelizabeth alisonelizabeth mentioned this pull request Jul 27, 2020
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jul 27, 2020
@alisonelizabeth
Make ingest node pipelines api tests more robust (elastic#73289)
49cd9d8
@alisonelizabeth alisonelizabeth mentioned this pull request Jul 27, 2020
Closed
alisonelizabeth added a commit that referenced this pull request Jul 28, 2020
@alisonelizabeth
Make ingest node pipelines api tests more robust (#73289) (#73340)
43425f9
alisonelizabeth added a commit that referenced this pull request Jul 28, 2020
@alisonelizabeth
Make ingest node pipelines api tests more robust (#73289) (#73341)
6d99816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @kibanamachine @elasticmachine @cjcenizal