Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] The unwanted icon shows up under the timeline template #89084

Closed
muskangulati-qasource opened this issue Jan 25, 2021 · 6 comments
Closed

[Security Solution] The unwanted icon shows up under the timeline template #89084

muskangulati-qasource opened this issue Jan 25, 2021 · 6 comments
Assignees
@andrew-goldstein @MadameSheema @manishgupta-qasource
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@muskangulati-qasource
Copy link

Describe the bug
The unwanted icon shows up under the timeline template

Build Details:

Version: 7.11.0 BC4
Commit: efd7b70e2803294a95395629dee55c89441d742a
Build number: 37776
Artifact: https://staging.elastic.co/7.11.0-c9f0a1f5/summary-7.11.0.html

Browser Details
All

Preconditions

  1. Cloud environment on staging should exist.
  2. Timeline templates should be loaded.

Steps to Reproduce

  1. Navigate to Kibana URL on Browser.
  2. Click on the "Timeline" tab under Security from the left navigation bar.
  3. Go to the Templates tab and click on any preloaded elastic template
  4. Observe that unwanted signs show up for the source.port column.

Test data
N/A

Impacted Test case(s)
N/A

Actual Result
The unwanted icon shows up under the timeline template

Expected Result
No unwanted icons should show up under the timeline template

What's Working
N/A

What's not Working
N/A

Screenshots
UnwantedSign

Logs
N/A
@muskangulati-qasource muskangulati-qasource added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. NeededFor:Onboarding and Lifecycle Mgt Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jan 25, 2021
@muskangulati-qasource muskangulati-qasource added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.11.0 and removed NeededFor:Onboarding and Lifecycle Mgt Team:Defend Workflows “EDR Workflows” sub-team of Security Solution enhancement New value added to drive a business result labels Jan 25, 2021
@muskangulati-qasource
Copy link
Author

@manishgupta-qasource please review!

@manishgupta-qasource
Copy link

Reviewed & Assigned to @MadameSheema

@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team and removed v7.11.0 labels Jan 25, 2021
@MadameSheema
Copy link
Member

@XavierM can you please help to prioritise this? Thanks :)

@XavierM XavierM added v7.11.1 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. in progress and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jan 27, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

Hi @XavierM

we have validated this issue on 7.11.2 BC1 On-Prem Environment and found it Not Fixed . As Still Duplicate not working open link icon for source.port and destination.port is coming in per-elastic template "Generic Network Timeline"

Issue is occurring on 7.12.0 BC3 too.
image

Build Details:

Version: 7.11.2 BC2
Platform: On-Prem
Commit: 70f09e46e6cdba697ba0929d9a9d5185687932c3
Build: 38010

Snapshot:

image

image

image

thanks!!

andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this issue Mar 9, 2021
@andrew-goldstein
## [Security Solution] Eliminates a redundant external link icon
7530340 
- Fixes an issue where [a redundant external link icon](elastic#89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
@andrew-goldstein andrew-goldstein mentioned this issue Mar 9, 2021
Merged
andrew-goldstein added a commit that referenced this issue Mar 11, 2021
@andrew-goldstein
[Security Solution] Eliminates a redundant external link icon (#94194)
14c32cb 
## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](#89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this issue Mar 11, 2021
@andrew-goldstein
[Security Solution] Eliminates a redundant external link icon (elasti…
8fc7582 
…c#94194)

## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](elastic#89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this issue Mar 11, 2021
@andrew-goldstein
[Security Solution] Eliminates a redundant external link icon (elasti…
3ad4947 
…c#94194)

## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](elastic#89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
andrew-goldstein added a commit that referenced this issue Mar 11, 2021
@andrew-goldstein
[Security Solution] Eliminates a redundant external link icon (#94194) (
0bce3bc 
#94387)

## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](#89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
andrew-goldstein added a commit that referenced this issue Mar 11, 2021
@andrew-goldstein
[Security Solution] Eliminates a redundant external link icon (#94194) (
623f43c 
#94388)

## [Security Solution] Eliminates a redundant external link icon

- Fixes an issue where [a redundant external link icon](#89084) was rendered next to port numbers

Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link.

- Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

### Before

<img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png">

### After

<img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png">

### Desk testing

Desk tested in:

- Chrome `89.0.4389.82`
- Firefox `86.0`
- Safari `14.0.3`
@XavierM XavierM added fixed and removed in progress labels Apr 7, 2021
@XavierM
Copy link
Contributor

XavierM commented Apr 7, 2021

@muskangulati-qasource can you please re-test it?

@muskangulati-qasource
Copy link
Author

Hi @XavierM,

We tested this on the latest 7.13.0-SNAPSHOT build & found that issue is now fixed.

Please find below the exact testing details:

Build Details:

Kibana Version: 7.13.0-SNAPSHOT
Build: 40075
Commit: 66cd29d44e5e2b41b63afe1a129fa8e8a946e6a8
Artifact Link: https://artifacts-api.elastic.co/v1/search/7.13.0-SNAPSHOT

Screenshot:
TemplateTab

Hence, closing this ticket and marking it as 'Validated'.

Thanks!!

@muskangulati-qasource muskangulati-qasource added the QA:Validated Issue has been validated by QA label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-goldstein andrew-goldstein

@MadameSheema MadameSheema

@manishgupta-qasource manishgupta-qasource

Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@XavierM @andrew-goldstein @MadameSheema @manishgupta-qasource @muskangulati-qasource