[Security Solution] Eliminates a redundant external link icon #94194

andrew-goldstein · 2021-03-09T20:35:58Z

[Security Solution] Eliminates a redundant external link icon

Fixes an issue where a redundant external link icon was rendered next to port numbers

Per the EuiLink documentation, it's no longer necessary to render our own icon, because EuiLink will automatically display one when target="_blank" is passed as a prop to the link.

Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions

Before

After

Desk testing

Desk tested in:

Chrome 89.0.4389.82
Firefox 86.0
Safari 14.0.3

- Fixes an issue where [a redundant external link icon](elastic#89084) was rendered next to port numbers Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link. - Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions ### Before <img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png"> ### After <img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png"> ### Desk testing Desk tested in: - Chrome `89.0.4389.82` - Firefox `86.0` - Safari `14.0.3`

elasticmachine · 2021-03-09T20:36:00Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

angorayc · 2021-03-10T12:03:09Z

@elasticmachine merge upstream

angorayc · 2021-03-10T13:02:33Z

Thanks @andrew-goldstein , it looks good with port, and we have some external links here, shall we apply the change to them in this PR as well?

andrew-goldstein · 2021-03-10T18:02:55Z

Thanks @andrew-goldstein , it looks good with port, and we have some external links here, shall we apply the change to them in this PR as well?

Great catch @angorayc!

I searched the project for all the places where we were using ExternalLinkIcon, and then after verifying each link was using _target="blank", removed the ExternalLinkIcon.

This ultimately eliminated all references to ExternalLinkIcon, which made it safe to also delete the ExternalLinkIcon component.

I didn't modify the Security news headlines and image-links (in the 2nd screenshot), because the behavior there is working as-designed.

x-pack/plugins/security_solution/public/common/components/links/index.tsx

kibanamachine · 2021-03-10T21:54:26Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2203	2202	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	-2.3KB

History

💔 Build #112554 failed 3898856
💚 Build #112429 succeeded 59ab509
💔 Build #112253 failed 7530340

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andrew-goldstein

…c#94194) ## [Security Solution] Eliminates a redundant external link icon - Fixes an issue where [a redundant external link icon](elastic#89084) was rendered next to port numbers Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link. - Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions ### Before <img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png"> ### After <img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png"> ### Desk testing Desk tested in: - Chrome `89.0.4389.82` - Firefox `86.0` - Safari `14.0.3`

#94387) ## [Security Solution] Eliminates a redundant external link icon - Fixes an issue where [a redundant external link icon](#89084) was rendered next to port numbers Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link. - Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions ### Before <img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png"> ### After <img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png"> ### Desk testing Desk tested in: - Chrome `89.0.4389.82` - Firefox `86.0` - Safari `14.0.3`

#94388) ## [Security Solution] Eliminates a redundant external link icon - Fixes an issue where [a redundant external link icon](#89084) was rendered next to port numbers Per the [EuiLink documentation](https://elastic.github.io/eui/#/navigation/link), it's no longer necessary to render our own icon, because `EuiLink` will automatically display one when `target="_blank"` is passed as a prop to the link. - Updates the existing link icon unit test such that it asserts a specific icon count to catch any regressions ### Before <img width="1673" alt="before" src="https://user-images.githubusercontent.com/4459398/110530119-4cd0ac00-80d7-11eb-9d54-5d6656491e69.png"> ### After <img width="1677" alt="after" src="https://user-images.githubusercontent.com/4459398/110530165-5c4ff500-80d7-11eb-99a3-68741fab9218.png"> ### Desk testing Desk tested in: - Chrome `89.0.4389.82` - Firefox `86.0` - Safari `14.0.3`

…-action * 'master' of github.com:elastic/kibana: (43 commits) [Console] Update copy when showing warnings in response headers (#94270) [TSVB] Type public code. Step 1 (#93231) [ML] Functional tests - stabilize slider value selection (#94313) skip another suite blocking es promotion (#94367) [Security Solution] Eliminates a redundant external link icon (#94194) skip another suite blocking es promotion (#94367) [App Search] Role mappings migration part 1 (#94346) [Security Solution][Detections] Fix flaky indicator enrichment tests (#94241) [Workplace Search] Deduplicate icons (#94359) [ML] Add latest transform to intro text (#94039) skip test failing es promotion (#94367) [Maps] convert elasticsearch_utils to TS (#93984) [Security_Solution][Telemetry] - Update endpoint usage to use agentService (#93829) [Security Solution][Exceptions] Fixes OS adding method for exception enrichment (#94343) [ILM] Add support for frozen phase (#93068) [App Search] Fixed 2 relevance tuning bugs (#94312) remove `try` auth mode (#94287) Removing resolver functional tests (#94331) migrate warning mixin to core (#94273) [App Search] Add routes for Role Mappings (#94221) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/phase/phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_issues_context.tsx

andrew-goldstein added release_note:fix v8.0.0 v7.12.0 Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0 labels Mar 9, 2021

andrew-goldstein self-assigned this Mar 9, 2021

andrew-goldstein requested a review from a team as a code owner March 9, 2021 20:35

andrew-goldstein added 2 commits March 10, 2021 10:46

- pr feedback

67ae143

Merge branch 'master' of github.com:elastic/kibana into port-icon-fix

3898856

andrew-goldstein force-pushed the port-icon-fix branch from 59ab509 to 3898856 Compare March 10, 2021 17:47

angorayc reviewed Mar 10, 2021

View reviewed changes

x-pack/plugins/security_solution/public/common/components/links/index.tsx Show resolved Hide resolved

angorayc approved these changes Mar 10, 2021

View reviewed changes

andrew-goldstein added 2 commits March 10, 2021 12:50

- render the comma after the icon

cf824f6

Merge branch 'master' of github.com:elastic/kibana into port-icon-fix

7c1893b

andrew-goldstein merged commit 14c32cb into elastic:master Mar 11, 2021

andrew-goldstein deleted the port-icon-fix branch March 11, 2021 00:17

andrew-goldstein mentioned this pull request Mar 11, 2021

[7.x] [Security Solution] Eliminates a redundant external link icon (#94194) #94387

Merged

andrew-goldstein mentioned this pull request Mar 11, 2021

[7.12] [Security Solution] Eliminates a redundant external link icon (#94194) #94388

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Eliminates a redundant external link icon #94194

[Security Solution] Eliminates a redundant external link icon #94194

andrew-goldstein commented Mar 9, 2021

elasticmachine commented Mar 9, 2021

angorayc commented Mar 10, 2021

angorayc commented Mar 10, 2021 •

edited

Loading

andrew-goldstein commented Mar 10, 2021

kibanamachine commented Mar 10, 2021

[Security Solution] Eliminates a redundant external link icon #94194

[Security Solution] Eliminates a redundant external link icon #94194

Conversation

andrew-goldstein commented Mar 9, 2021