Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix fleet server collector in case settings are not set #101752

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jun 9, 2021

Summary

Related to #101400

When fetching data for telemetry we retrieve the Fleet settings Saved Object sometime this saved object could not be created, we should handle this gracefully

   │ proc [kibana] server    log   [16:54:50.238] [warning][collector-set][plugins][usage-collection][usageCollection] Error: Global settings not found
   │ proc [kibana]     at Object.getSettings (/Users/nicolas/Workspace/kibana/x-pack/plugins/fleet/server/services/settings.ts:23:16)

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 9, 2021
@nchaulet nchaulet requested a review from kpollich June 9, 2021 13:35
@nchaulet nchaulet self-assigned this Jun 9, 2021
@nchaulet nchaulet requested a review from a team as a code owner June 9, 2021 13:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet requested a review from Zacqary June 10, 2021 15:32
@nchaulet nchaulet enabled auto-merge (squash) June 10, 2021 20:31
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

@nchaulet nchaulet deleted the fix-fleet-server-collector-not-settings branch June 10, 2021 20:41
kibanamachine added a commit that referenced this pull request Jun 10, 2021
) (#101960)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 14, 2021
* master: (68 commits)
  skip flaky suite (elastic#94043)
  skip flaky suite (elastic#102012)
  [esArchive] Persists updates for management/saved_objects/* (elastic#101992)
  skip flaky suite (elastic#101449)
  remove unnecessary hack (elastic#101909)
  [Exploratory View] Use human readable formats (elastic#101520)
  [Expressions] Refactor expression functions to use observables underneath (elastic#100409)
  [esArchives] Persist migrated Kibana archives (elastic#101950)
  [kbnArchiver] fix save to non-existent file (elastic#101974)
  [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957)
  [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696)
  [Observability] [Cases] Cases in the observability app (elastic#101487)
  [Alerting][Docs] Combine rule creation and management pages (elastic#101498)
  temporarily disable build-buddy
  [Fleet] Fix fleet server collector in case settings are not set (elastic#101752)
  [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132)
  [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690)
  Add comments to some alerting plugin public API items (elastic#101551)
  [Alerting][Docs] Moving alerting setup to its own page (elastic#101323)
  remove uptime public API, it's not used. (elastic#101799)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants