Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Fix OR logic on redundant groupBy detection #116695

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 28, 2021

Summary

Fixes #116195

In this PR, host.name will still be flagged as redundant in this case:
Screen Shot 2021-10-28 at 12 32 34 PM

But with these changes, it will NOT be flagged in this case:
Screen Shot 2021-10-28 at 12 34 46 PM
Screen Shot 2021-10-28 at 12 34 32 PM

@Zacqary Zacqary added release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 28, 2021
@Zacqary Zacqary requested a review from a team as a code owner October 28, 2021 17:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 28, 2021

Another issue I just noticed is that I don't think agent.hostname should be flagged in this case:
Screen Shot 2021-10-28 at 12 39 09 PM

Fixing this might be a more complicated change, though, so I wonder if we should scope it to a later PR.

Not sure how common a query like this would even be.

@Zacqary Zacqary enabled auto-merge (squash) October 28, 2021 19:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 928.9KB 928.9KB +56.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian self-requested a review October 29, 2021 13:53
@neptunian
Copy link
Contributor

I wonder if instead of trying to validate their inputs we can make it more generic and anytime they are filtering on a field that is also being grouped there can be a generic warning message that they may get unexpected results and then link to some documentation explaining how and why with some examples. Even if they are using an OR like in the issue #116195, it seems still valid to notify them that they'd get less results than may be expected.

@brianseeders brianseeders changed the base branch from main to master October 29, 2021 15:17
@Zacqary Zacqary changed the base branch from master to main October 29, 2021 16:04
@Zacqary
Copy link
Contributor Author

Zacqary commented Oct 29, 2021

@neptunian Yeah that approach makes more sense. I can see about writing up some docs for this and redo this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Threshold alert redundant groupBy throws a false positive on OR matches
4 participants