Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Metrics UI] Fix OR logic on redundant groupBy detection" #116820

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Revert "[Metrics UI] Fix OR logic on redundant groupBy detection" #116820

merged 1 commit into from
Oct 29, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Oct 29, 2021

Reverts #116695

main is not yet protected from auto-merge

@Zacqary Zacqary added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 29, 2021
@Zacqary Zacqary requested a review from a team as a code owner October 29, 2021 18:09
@Zacqary Zacqary enabled auto-merge (squash) October 29, 2021 18:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 927.1KB 927.0KB -56.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 285cd00 into main Oct 29, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116820 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116820 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116820 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116820 or prevent reminders by adding the backport:skip label.

@weltenwort weltenwort added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 8, 2021
@kibanamachine kibanamachine mentioned this pull request Jan 26, 2022
Merged
@spalger spalger deleted the revert-116695-116195-groupby-or-fix branch May 8, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zacqary @kibanamachine @neptunian @weltenwort