Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.16] [Fleet] Make integration names globally unique (#115212) #117380

Merged
merged 8 commits into from
Nov 15, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.16:

* [Fleet] Make integration names globally unique

* Fix Jest tests

* Append (copy) to names of integration packages belonging to duplicated policy

* Update current policy maintaining its name

* Fix failing tests
@criamico
Copy link
Contributor

criamico commented Nov 4, 2021

@elasticmachine merge upstream

@criamico
Copy link
Contributor

criamico commented Nov 4, 2021

@elasticmachine merge upstream

@jen-huang
Copy link
Contributor

@elasticmachine merge upstream

@jen-huang
Copy link
Contributor

jen-huang commented Nov 4, 2021

@criamico I haven't looked at the CI errors that closely but I see they are related to Endpoint tests. It is entirely possible that those tests are attempting to setting up policies with same names which your changes now disallow so please have a closer look if the CI continues to fail :)

@criamico
Copy link
Contributor

criamico commented Nov 5, 2021

@elasticmachine merge upstream

@criamico
Copy link
Contributor

criamico commented Nov 8, 2021

@elasticmachine merge upstream

@criamico
Copy link
Contributor

criamico commented Nov 9, 2021

@elasticmachine merge upstream

@criamico
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 617.3KB 617.5KB +185.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@kibanamachine kibanamachine merged commit 060b8b0 into elastic:7.16 Nov 15, 2021
@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants