[Security Solution] fix tests for unique policy names #118248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
added
auto-backport
joeypoon
commented
Nov 10, 2021
| @@ -139,12 +140,13 @@ export async function indexEndpointHostDocs({ | |||
|
|
|||
| if (enrollFleet) { | |||
| const { id: appliedPolicyId, name: appliedPolicyName } = hostMetadata.Endpoint.policy.applied; | |||
| const uniqueAppliedPolicyName = `${appliedPolicyName}-${uuid.v4()}`; | |||
There was a problem hiding this comment.
I think ideally we do this within the data generator itself but since this is blocking us from unskipping our tests, I want to make the smallest changes possible for this PR.
1 task
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
academo
approved these changes
Nov 11, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
claudiopro
pushed a commit
to claudiopro/kibana
that referenced
this pull request
Nov 11, 2021
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Nov 17, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
roeehub
pushed a commit
to build-security/kibana
that referenced
this pull request
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes endpoint tests that were failing due to policy names not being unique. unique policies names were introduced in #115212. needs to be back-ported into
7.16for #117380.Checklist
For maintainers