Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates publicBaseUrl warning copy #126296

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Updates publicBaseUrl warning copy #126296

merged 3 commits into from
Feb 24, 2022

Conversation

TinaHeiligers
Copy link
Contributor

Summary

Resolves #109970.
Updates copy in the publicBaseUrl warning shown when server.publicBaseUrl is not configured.

Screen Shot 2022-02-23 at 12 05 49 PM

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

For maintainers

@TinaHeiligers TinaHeiligers added Feature:Configuration Settings in kibana.yml release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0 ci:deploy-cloud labels Feb 23, 2022
@TinaHeiligers TinaHeiligers marked this pull request as ready for review February 23, 2022 23:29
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner February 23, 2022 23:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

lukeelmers
lukeelmers approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It'd be nice to have more explanation in the docs of the benefits of including this setting, as you suggested in #109970 (comment), but I think we should leave that to the alerting/reporting folks in a separate PR.

@gchaps
Copy link
Contributor

gchaps commented Feb 23, 2022

I like the positive spin you put on the title.

In the UI, we typically say "Learn more" instead of "Refer to the documentation".

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Feb 24, 2022 •
edited
Loading

In the UI, we typically say "Learn more" instead of "Refer to the documentation".

@gchaps, thanks, I'll update that

@TinaHeiligers TinaHeiligers enabled auto-merge (squash) February 24, 2022 00:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 292.7KB 292.7KB -57.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit 69255e7 into elastic:main Feb 24, 2022
@TinaHeiligers TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 24, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 126296

Questions ?

Please refer to the Backport tool documentation

@gchaps gchaps added the ui-copy Review of UI copy with docs team is recommended label Feb 24, 2022
@TinaHeiligers TinaHeiligers deleted the friendlier-publicBaseUrl-warning branch February 24, 2022 20:00
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126296 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 25, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126296 or prevent reminders by adding the backport:skip label.

@pgayvallet pgayvallet added the backport:skip This commit does not require backporting label Mar 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 1, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@TinaHeiligers @lucasfcosta
Updates publicBaseUrl warning copy (elastic#126296)
ffb06a6
@rashmivkulkarni
Copy link
Contributor

This should also have been backported to 7.17 branch as well. ( also on 8.1- probably too late now)

cc @TinaHeiligers

@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Configuration Settings in kibana.yml release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc ui-copy Review of UI copy with docs team is recommended v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] publicBaseUrl warning seems too scary
9 participants
@TinaHeiligers @elasticmachine @gchaps @kibana-ci @kibanamachine @rashmivkulkarni @lukeelmers @tylersmalley @pgayvallet