Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates publicBaseUrl warning copy #126296

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Updates publicBaseUrl warning copy #126296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b89676
Updates publicBaseUrl warning copy
TinaHeiligers Feb 23, 2022
1404742
Merge branch 'main' into friendlier-publicBaseUrl-warning
TinaHeiligers Feb 23, 2022
85a8860
Improves documentation link label
TinaHeiligers Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/public/core_app/errors/public_base_url.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe('publicBaseUrl warning', () => {
});

expect(notifications.toasts.addWarning).toHaveBeenCalledWith({
title: 'Configuration missing',
title: 'Configuration recommended',
text: expect.any(Function),
});
});
Expand Down
12 changes: 6 additions & 6 deletions src/core/public/core_app/errors/public_base_url.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,23 @@ export const setupPublicBaseUrlConfigWarning = ({
}

const toast = notifications.toasts.addWarning({
title: i18n.translate('core.ui.publicBaseUrlWarning.configMissingTitle', {
defaultMessage: 'Configuration missing',
title: i18n.translate('core.ui.publicBaseUrlWarning.configRecommendedTitle', {
defaultMessage: 'Configuration recommended',
}),
text: mountReactNode(
<>
<p>
<FormattedMessage
id="core.ui.publicBaseUrlWarning.configMissingDescription"
defaultMessage="{configKey} is missing and should be configured when running in a production environment. Some features may not behave correctly."
id="core.ui.publicBaseUrlWarning.configRecommendedDescription"
defaultMessage="In a production environment, it is recommended that you configure {configKey}."
values={{
configKey: <code>server.publicBaseUrl</code>,
}}
/>{' '}
<a href={`${docLinks.links.settings}#server-publicBaseUrl`} target="_blank">
<FormattedMessage
id="core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel"
defaultMessage="See the documentation."
id="core.ui.publicBaseUrlWarning.learnMoreLinkLabel"
defaultMessage="Learn more."
/>
</a>
</p>
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,10 +1636,7 @@
"core.ui.primaryNav.screenReaderLabel": "プライマリ",
"core.ui.primaryNav.toggleNavAriaLabel": "プライマリナビゲーションを切り替える",
"core.ui.primaryNavSection.screenReaderLabel": "プライマリナビゲーションリンク、{category}",
"core.ui.publicBaseUrlWarning.configMissingDescription": "{configKey}が見つかりません。本番環境を実行するときに構成してください。一部の機能が正常に動作しない場合があります。",
"core.ui.publicBaseUrlWarning.configMissingTitle": "構成がありません",
"core.ui.publicBaseUrlWarning.muteWarningButtonLabel": "ミュート警告",
"core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel": "ドキュメントを参照してください。",
"core.ui.recentLinks.linkItem.screenReaderLabel": "{recentlyAccessedItemLinklabel}、タイプ：{pageType}",
"core.ui.recentlyViewed": "最近閲覧",
"core.ui.recentlyViewedAriaLabel": "最近閲覧したリンク",
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,10 +1643,7 @@
"core.ui.primaryNav.screenReaderLabel": "主分片",
"core.ui.primaryNav.toggleNavAriaLabel": "切换主导航",
"core.ui.primaryNavSection.screenReaderLabel": "主导航链接, {category}",
"core.ui.publicBaseUrlWarning.configMissingDescription": "{configKey} 缺失，在生产环境中运行时应配置。某些功能可能运行不正常。",
"core.ui.publicBaseUrlWarning.configMissingTitle": "配置缺失",
"core.ui.publicBaseUrlWarning.muteWarningButtonLabel": "静音警告",
"core.ui.publicBaseUrlWarning.seeDocumentationLinkLabel": "请参阅文档。",
"core.ui.recentLinks.linkItem.screenReaderLabel": "{recentlyAccessedItemLinklabel}，类型：{pageType}",
"core.ui.recentlyViewed": "最近查看",
"core.ui.recentlyViewedAriaLabel": "最近查看的链接",
Expand Down