[Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app #144176

dominiqueclarke · 2022-10-28T15:52:55Z

Summary

Standardizes the uses of ConfigKey.MONITOR_QUERY_ID and CONFIG_KEY.CONFIG_ID throughout the public app.

ConfigKey	string value of config key	Responsibility
CONFIG_ID	'id'	Represents the id which should be used for ES queries
CONFIG_ID	'config_id'	Represents the id which should be used for fetching saved object configuration

Regression testing

This PR requires full manual regression testing for the Synthetics app.

Create a UI browser monitor and lightweight monitor
Create a project monitor browser monitor and lightweight monitor
Navigate to Uptime.
Ensure that when you click on the edit button, it navigates to the monitor edit page
Ensure that when you click on the name, it navigates to the monitor pings page
Navigate to Synthetics UI
Ensure that the metric item is populated with the average duration
Ensure that clicking on the metric item populates the monitor flyout with correct information and the duration chart
Click the actions and disable the monitor. Ensure the monitor is able to be disabled
Click the edit button and ensure it navigates to the monitor appropriately
Click on the monitor grid item. Ensure the the monitor details page populates appropriately.
Click view history on the last 10 pings. Ensure the history is populated appropriately
For browser monitors: ensure that step details page works correctly

…-ref HEAD~1..HEAD --fix'

…hub.com/dominiqueclarke/kibana into feature/synthetics-monitor-id-migration

…ics-monitor-id-migration

…BEAT_ID

…ics-monitor-id-migration

…ics-monitor-id-hook

elasticmachine · 2022-11-09T19:03:01Z

Pinging @elastic/uptime (Team:uptime)

shahzad31 · 2022-11-10T11:00:03Z

...synthetics/public/apps/synthetics/components/monitor_details/monitor_errors/failed_tests.tsx

+  const monitorId = useMonitorQueryId();
+
+  if (!monitorId) {
+    return null;


May be a loading here? or maybe monitorId should be passed from parent component and there we can a central loading.

What loader do you think we should have, since most of these are exploratory view visualizations.

shahzad31 · 2022-11-10T11:06:40Z

x-pack/plugins/synthetics/public/apps/synthetics/state/monitor_details/api.ts

@@ -75,7 +75,6 @@ export const fetchSyntheticsMonitor = async ({

  return {
    ...savedObject.attributes,
-    id: savedObject.id,


why is this removed?

It was removed in favor of MONITOR_QUERY_ID, which is on the attributes. Now, there's no longer an id field on the front end that is the monitor saved object id. Instead, we rely on CONFIG_ID for that value.

…ics-monitor-id-hook

…-fix'

…ics-monitor-id-hook

...thetics/public/apps/synthetics/components/monitor_details/monitor_summary/duration_trend.tsx

…nitor_details/monitor_summary/duration_trend.tsx

…-ref HEAD~1..HEAD --fix'

kibana-ci · 2022-11-15T11:13:54Z

💚 Build Succeeded

Buildkite Build
Commit: d4da6f8

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	1.1MB	1.1MB	+88.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	108	113	+5
`securitySolution`	441	447	+6
total			+19

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	67	73	+6
`osquery`	109	115	+6
`securitySolution`	518	524	+6
total			+20

History

💔 Build #87892 failed da8bf96
💔 Build #87754 failed af94c32
💔 Build #87594 failed 6916334
💔 Build #87482 failed 2a91b3a
💚 Build #86969 succeeded 30823eb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…hroughout the app (elastic#144176) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: shahzad31 <shahzad.muhammad@elastic.co> Co-authored-by: Shahzad <shahzad31comp@gmail.com> Resolves elastic#143309

dominiqueclarke and others added 22 commits October 24, 2022 12:41

synthetics - add monitor id migration

43cce31

add id to all monitors

9bf96f9

add config id to migration

508278a

adjust import

06a0434

update tests

56c8e44

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

71c47a6

…-ref HEAD~1..HEAD --fix'

update tests

1e3fba1

Merge branch 'feature/synthetics-monitor-id-migration' of https://git…

26d8a92

…hub.com/dominiqueclarke/kibana into feature/synthetics-monitor-id-migration

adjust types

2f72667

Merge branch 'main' into feature/synthetics-monitor-id-migration

fd4bd4e

rename id key

4757a83

Merge branch 'feature/synthetics-monitor-id-migration' of https://git…

f58fb0a

…hub.com/dominiqueclarke/kibana into feature/synthetics-monitor-id-migration

rename id key

558e7fc

adjust types and tests

2c14464

adjust test

1e3acaa

Merge branch 'main' of github.com:elastic/kibana into feature/synthet…

cef4828

…ics-monitor-id-migration

synthetics - update references to CUSTOM_HEARTBEAT_ID to prefer HEART…

15414c5

…BEAT_ID

update formatHeartbeatRequest

1f37768

update legacy uptime monitor details saved object query

93681bf

update jest test

887f0c0

adjust tests

ea01bb8

adjust tests

53c1d9e

dominiqueclarke force-pushed the feature/synthetics-monitor-id-hook branch from 30b6411 to 53c1d9e Compare October 28, 2022 21:14

dominiqueclarke added 7 commits October 28, 2022 17:16

update selectors and hooks

6ba17df

Merge branch 'main' of github.com:elastic/kibana into feature/synthet…

64c9fe6

…ics-monitor-id-migration

rename HEARTBEAT_ID to MONITOR_QUERY_ID

d7a5fa9

update flaky test

9e62978

merge upstream

8c790db

merge migration upstream

7a642d5

Merge branch 'main' of github.com:elastic/kibana into feature/synthet…

628463f

…ics-monitor-id-hook

dominiqueclarke requested a review from a team as a code owner November 9, 2022 19:02

dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 9, 2022

dominiqueclarke changed the title ~~Feature/synthetics monitor id hook~~ [Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app Nov 9, 2022

shahzad31 reviewed Nov 10, 2022

View reviewed changes

shahzad31 and others added 6 commits November 10, 2022 12:17

Merge branch 'main' of github.com:elastic/kibana into feature/synthet…

4e5e0de

…ics-monitor-id-hook

resolve conflicts

df6fd23

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

30823eb

…-fix'

Merge branch 'main' into feature/synthetics-monitor-id-hook

2a91b3a

update types

1d4cac2

Merge branch 'main' of github.com:elastic/kibana into feature/synthet…

6916334

…ics-monitor-id-hook

shahzad31 approved these changes Nov 14, 2022

View reviewed changes

dominiqueclarke and others added 2 commits November 14, 2022 15:51

Merge branch 'main' into feature/synthetics-monitor-id-hook

af94c32

Merge branch 'main' into feature/synthetics-monitor-id-hook

da8bf96

shahzad31 reviewed Nov 15, 2022

View reviewed changes

...thetics/public/apps/synthetics/components/monitor_details/monitor_summary/duration_trend.tsx Outdated Show resolved Hide resolved

shahzad31 and others added 2 commits November 15, 2022 11:09

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

9d6c1ac

…nitor_details/monitor_summary/duration_trend.tsx

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

d4da6f8

…-ref HEAD~1..HEAD --fix'

shahzad31 merged commit 95a0f2e into elastic:main Nov 15, 2022

kibanamachine added the backport:skip This commit does not require backporting label Nov 15, 2022

shahzad31 deleted the feature/synthetics-monitor-id-hook branch November 15, 2022 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app #144176

[Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app #144176

dominiqueclarke commented Oct 28, 2022 •

edited

Loading

elasticmachine commented Nov 9, 2022

shahzad31 Nov 10, 2022

dominiqueclarke Nov 14, 2022

shahzad31 Nov 10, 2022

dominiqueclarke Nov 14, 2022

kibana-ci commented Nov 15, 2022

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

[Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app #144176

[Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app #144176

Conversation

dominiqueclarke commented Oct 28, 2022 • edited Loading

Summary

Regression testing

elasticmachine commented Nov 9, 2022

shahzad31 Nov 10, 2022

Choose a reason for hiding this comment

dominiqueclarke Nov 14, 2022

Choose a reason for hiding this comment

shahzad31 Nov 10, 2022

Choose a reason for hiding this comment

dominiqueclarke Nov 14, 2022

Choose a reason for hiding this comment

kibana-ci commented Nov 15, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

dominiqueclarke commented Oct 28, 2022 •

edited

Loading