-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Standardize the uses of MONITOR_QUERY_ID and CONFIG_ID throughout the app #144176
Changes from 40 commits
43cce31
9bf96f9
508278a
06a0434
56c8e44
71c47a6
1e3fba1
26d8a92
2f72667
fd4bd4e
4757a83
f58fb0a
558e7fc
2c14464
1e3acaa
cef4828
15414c5
1f37768
93681bf
887f0c0
ea01bb8
53c1d9e
6ba17df
64c9fe6
d7a5fa9
9e62978
8c790db
7a642d5
628463f
b81bd78
739b1f6
734e519
1fc1bd0
bc09dc7
7571acd
b5fa7c7
36bed4a
88d6ec0
d2ad438
3b5727c
4e5e0de
df6fd23
30823eb
2a91b3a
1d4cac2
6916334
af94c32
da8bf96
9d6c1ac
d4da6f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,7 +75,6 @@ export const fetchSyntheticsMonitor = async ({ | |
|
||
return { | ||
...savedObject.attributes, | ||
id: savedObject.id, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this removed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was removed in favor of |
||
updated_at: savedObject.updated_at, | ||
} as EncryptedSyntheticsSavedMonitor; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be a loading here? or maybe monitorId should be passed from parent component and there we can a central loading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What loader do you think we should have, since most of these are exploratory view visualizations.