Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Allow updates for number of allocations and priority for trained model deployments #144704

Merged
merged 13 commits into from
Nov 15, 2022
Merged

[ML] Allow updates for number of allocations and priority for trained model deployments #144704

merged 13 commits into from
Nov 15, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Nov 7, 2022 •
edited
Loading

Summary

Resolves #144550 and #144595

Adds a new action to the Trained Models table to update the number of allocations for already started deployments.

image

Sets priority while starting a deployment
image

Checklist

@darnautov darnautov added release_note:enhancement :ml Feature:3rd Party Models ML 3rd party models Team:ML Team label for ML (also use :ml) v8.6.0 labels Nov 7, 2022
@darnautov darnautov requested a review from a team as a code owner November 7, 2022 13:24
@darnautov darnautov self-assigned this Nov 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and overall looks good.

Would be good to verify on cloud once #144793 is merged.

@darnautov darnautov changed the title [ML] Update number of allocations for started deployments [ML] Allow updates for number of allocations and priority for trained model deployments Nov 9, 2022
@darnautov
Copy link
Contributor Author

darnautov commented Nov 14, 2022 •
edited
Loading

Tested locally and overall looks good.

Would be good to verify on cloud once #144793 is merged.

@peteharverson Updated in 92ee445

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1567 1568 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +3.7KB
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
ml 570 569 -1
osquery 108 113 +5
securitySolution 441 447 +6
total +18

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
ml 573 572 -1
osquery 109 115 +6
securitySolution 518 524 +6
total +19

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

jgowdyelastic
jgowdyelastic approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment about the capability being used on the endpoint. but other than than LGTM

x-pack/plugins/ml/server/routes/trained_models.ts
body: updateDeploymentParamsSchema,
},
options: {
tags: ['access:ml:canStartStopTrainedModels'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canCreateTrainedModels is probably a better match for this endpoint action.

peteharverson
peteharverson approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest change to check for a cloud trial LGTM

@darnautov darnautov merged commit ca49da1 into elastic:main Nov 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 15, 2022
@darnautov darnautov deleted the ml-144550-update-number-of-allocations branch November 15, 2022 09:00
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2022
@jloleysens
Merge branch 'main' into files-management
6c5fb8a 
* main: (65 commits)
  Migrate server-side `Root` and `Server` to packages (elastic#144990)
  [Discover] Handle no data views state for `esQuery` alert (elastic#145052)
  [ML] Allow updates for number of allocations and priority for trained model deployments (elastic#144704)
  [api-docs] 2022-11-15 Daily api_docs build (elastic#145203)
  [Security solution] remove guided onboarding feature flag (elastic#144247)
  [DOCS] Automate final case APIs (elastic#145007)
  [Enterprise Search] Name and description flyout for connectors (elastic#143827)
  [Guided onboarding] Update header button logic (elastic#144634)
  [Lens] Multi metric partition charts (elastic#143966)
  [Dashboard] [Controls] Add unmapped runtime field support to options list (elastic#144947)
  [Security Solution] Add Task Metric Collection to New Tasks (elastic#145181)
  [TriggersActionsUi] disable jest config in CI (elastic#145186)
  [TableListView] Enhance tag filtering (elastic#142108)
  [Cloud Posture] Compliance by CIS section table (elastic#145114)
  [8.6][Session View] Fix hidden alert flyout  in session view (elastic#145141)
  [customIntegrations] async load all components (elastic#145166)
  Fix time for logs smoke tests in integration test (elastic#145130)
  [RAM] Update rule status (elastic#140882)
  Update babel (main) (elastic#145060)
  [Actionable Observability] Add context.alertDetailsUrl variable to action connector template for APM rule types (elastic#144791)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Update number of allocations for started deployments
6 participants
@darnautov @elasticmachine @kibana-ci @peteharverson @jgowdyelastic @kibanamachine