Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Automate final case APIs #145007

Merged
merged 7 commits into from
Nov 15, 2022
Merged

[DOCS] Automate final case APIs #145007

merged 7 commits into from
Nov 15, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 10, 2022

Summary

Relates to #137240

This PR uses the open API v3 specification (OAS) to generate output for the following APIs:

  • find cases
  • find connectors
  • get case activity
  • get alerts attached to case

It takes output from the open-api generator, in particular the HTML generator, applies a custom template and uses that output in a passthrough block in an appendix in the Kibana Guide.

The changes to the specification are as follows:

  • created an assignees.yaml file to be re-used across multiple endpoints
  • adds the missing assignees reference to the payload for create_case activity
  • fixes the way the payload is marked as nullable for the delete_case activity
  • fixes some re-use of user_properties.yaml

This PR also removes the -min. temporary files, since we've now completed the full set of case APIs.

@lcawl lcawl added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Cases Cases feature v8.6.0 v8.5.1 labels Nov 10, 2022
@github-actions
Copy link
Contributor

Documentation preview:

@lcawl lcawl requested a review from a team November 10, 2022 22:48
@lcawl lcawl marked this pull request as ready for review November 10, 2022 22:49
@lcawl lcawl requested a review from a team as a code owner November 10, 2022 22:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@@ -1,5 +1,7 @@
type: object
properties:
assignees:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assignees property is optional (as the severity). Is this captured in theassignees.yaml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All properties are assumed to be optional in an object; if there are required properties, we'd need to add a "required" list per https://swagger.io/docs/specification/data-models/data-types/#object

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks, Lisa! Should we put the title, the description, etc on the "required" list?

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Nov 14, 2022
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, congrats! :)

@lcawl lcawl enabled auto-merge (squash) November 15, 2022 01:21
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 5348e39 into elastic:main Nov 15, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.5 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 145007

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2022
* main: (65 commits)
  Migrate server-side `Root` and `Server` to packages (elastic#144990)
  [Discover] Handle no data views state for `esQuery` alert (elastic#145052)
  [ML] Allow updates for number of allocations and priority for trained model deployments (elastic#144704)
  [api-docs] 2022-11-15 Daily api_docs build (elastic#145203)
  [Security solution] remove guided onboarding feature flag (elastic#144247)
  [DOCS] Automate final case APIs (elastic#145007)
  [Enterprise Search] Name and description flyout for connectors (elastic#143827)
  [Guided onboarding] Update header button logic (elastic#144634)
  [Lens] Multi metric partition charts (elastic#143966)
  [Dashboard] [Controls] Add unmapped runtime field support to options list (elastic#144947)
  [Security Solution] Add Task Metric Collection to New Tasks (elastic#145181)
  [TriggersActionsUi] disable jest config in CI (elastic#145186)
  [TableListView] Enhance tag filtering (elastic#142108)
  [Cloud Posture] Compliance by CIS section table (elastic#145114)
  [8.6][Session View] Fix hidden alert flyout  in session view (elastic#145141)
  [customIntegrations] async load all components (elastic#145166)
  Fix time for logs smoke tests in integration test (elastic#145130)
  [RAM] Update rule status (elastic#140882)
  Update babel (main) (elastic#145060)
  [Actionable Observability] Add context.alertDetailsUrl variable to action connector template for APM rule types (elastic#144791)
  ...
@lcawl lcawl deleted the find-cases branch November 15, 2022 16:15
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 15, 2022
@lcawl
Copy link
Contributor Author

lcawl commented Nov 15, 2022

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants