Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] fix time slider play button display=fill property not being respected #145417

Merged
merged 2 commits into from
Nov 16, 2022
Merged

[Controls] fix time slider play button display=fill property not being respected #145417

merged 2 commits into from
Nov 16, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 16, 2022

resolves #145301

Steps to test

  • create new dashboard
  • Add time slider control
  • verify play toggle button has primary color background

Screen Shot 2022-11-16 at 9 56 00 AM

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.6.0 v8.7.0 labels Nov 16, 2022
@nreese nreese requested review from a team as code owners November 16, 2022 16:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Nov 16, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
controls 474.0KB 474.1KB +147.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson
ThomThomson approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions LGTM! Code only review

@nreese nreese merged commit de39dba into elastic:main Nov 16, 2022
kibanamachine pushed a commit that referenced this pull request Nov 16, 2022
@nreese
[Controls] fix time slider play button display=fill property not bein…
4d99c64 
…g respected (#145417)

resolves #145301

Steps to test
* create new dashboard
* Add time slider control
* verify play toggle button has primary color background

<img width="600" alt="Screen Shot 2022-11-16 at 9 56 00 AM"
src="https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png">

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit de39dba)
@kibanamachine kibanamachine mentioned this pull request Nov 16, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Nov 16, 2022
@kibanamachine @nreese
[8.6] [Controls] fix time slider play button display=fill property no…
72899bd 
…t being respected (#145417) (#145447)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Controls] fix time slider play button display=fill property not
being respected
(#145417)](#145417)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2022-11-16T20:19:53Z","message":"[Controls]
fix time slider play button display=fill property not being respected
(#145417)\n\nresolves
https://github.com/elastic/kibana/issues/145301\r\n\r\nSteps to
test\r\n* create new dashboard\r\n* Add time slider control\r\n* verify
play toggle button has primary color background\r\n\r\n<img
width=\"600\" alt=\"Screen Shot 2022-11-16 at 9 56 00
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de39dba2c49959293a970b271a588269ba11ed0e","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","auto-backport","v8.6.0","v8.7.0"],"number":145417,"url":"https://github.com/elastic/kibana/pull/145417","mergeCommit":{"message":"[Controls]
fix time slider play button display=fill property not being respected
(#145417)\n\nresolves
https://github.com/elastic/kibana/issues/145301\r\n\r\nSteps to
test\r\n* create new dashboard\r\n* Add time slider control\r\n* verify
play toggle button has primary color background\r\n\r\n<img
width=\"600\" alt=\"Screen Shot 2022-11-16 at 9 56 00
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de39dba2c49959293a970b271a588269ba11ed0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145417","number":145417,"mergeCommit":{"message":"[Controls]
fix time slider play button display=fill property not being respected
(#145417)\n\nresolves
https://github.com/elastic/kibana/issues/145301\r\n\r\nSteps to
test\r\n* create new dashboard\r\n* Add time slider control\r\n* verify
play toggle button has primary color background\r\n\r\n<img
width=\"600\" alt=\"Screen Shot 2022-11-16 at 9 56 00
AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by:
Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"de39dba2c49959293a970b271a588269ba11ed0e"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Nov 17, 2022
@nreese @kibanamachine @benakansara
[Controls] fix time slider play button display=fill property not bein…
2ade56e 
…g respected (elastic#145417)

resolves elastic#145301

Steps to test
* create new dashboard
* Add time slider control
* verify play toggle button has primary color background

<img width="600" alt="Screen Shot 2022-11-16 at 9 56 00 AM"
src="https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png">

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[controls] time slider play button "display=fill" property not being respected
6 participants
@nreese @elasticmachine @kibana-ci @kibanamachine @ryankeairns @ThomThomson