Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add title in apm settings callout #145857

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[APM] Add title in apm settings callout #145857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions x-pack/plugins/apm/public/components/app/settings/general_settings/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ export function GeneralSettings() {
return (
<>
<EuiCallOut
title={
title={i18n.translate('xpack.apm.apmSettings.callOutTitle', {
defaultMessage: 'Looking for all settings?',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is just a suggestion, if you have a better one please let me know :D

})}
iconType="search"
>
<p>
<FormattedMessage
id="xpack.apm.apmSettings.kibanaLink"
defaultMessage="The full list of APM options can be found in {link}"
Expand All @@ -82,15 +87,14 @@ export function GeneralSettings() {
})}
>
{i18n.translate('xpack.apm.apmSettings.kibanaLink.label', {
defaultMessage: 'Kibana advanced settings',
defaultMessage: 'Kibana advanced settings.',
})}
</EuiLink>
),
}}
/>
}
iconType="iInCircle"
/>
</p>
</EuiCallOut>
<EuiSpacer />
{apmSettingsKeys.map((settingKey) => {
const editableConfig = settingsEditableConfig[settingKey];
Expand Down