[APM] Add title in apm settings callout #145857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpatticha
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:APM) |
kpatticha
commented
Nov 21, 2022
| @@ -70,7 +70,12 @@ export function GeneralSettings() { | |||
| return ( | |||
| <> | |||
| <EuiCallOut | |||
| title={ | |||
| title={i18n.translate('xpack.apm.apmSettings.callOutTitle', { | |||
| defaultMessage: 'Looking for all settings?', | |||
There was a problem hiding this comment.
The title is just a suggestion, if you have a better one please let me know :D
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2022
## Summary closes elastic#145849 Before  After  (cherry picked from commit 40de9eb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[APM] Add title in apm settings callout (#145857)](#145857) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Katerina Patticha","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2022-11-21T18:40:38Z","message":"[APM] Add title in apm settings callout (#145857)\n\n## Summary\r\ncloses https://github.com/elastic/kibana/issues/145849\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.6.0","v8.7.0"],"number":145857,"url":"https://github.com/elastic/kibana/pull/145857","mergeCommit":{"message":"[APM] Add title in apm settings callout (#145857)\n\n## Summary\r\ncloses https://github.com/elastic/kibana/issues/145849\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145857","number":145857,"mergeCommit":{"message":"[APM] Add title in apm settings callout (#145857)\n\n## Summary\r\ncloses https://github.com/elastic/kibana/issues/145849\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab"}}]}] BACKPORT--> Co-authored-by: Katerina Patticha <aikaterini.patticha@elastic.co>
\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.6.0","v8.7.0"],"number":145857,"url":"https://github.com/elastic/kibana/pull/145857","mergeCommit":{"message":"[APM]](https://github.com/elastic/kibana/issues/145849\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.6.0","v8.7.0"],"number":145857,"url":"https://github.com/elastic/kibana/pull/145857","mergeCommit":{"message":"[APM]){kind=link}
\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145857","number":145857,"mergeCommit":{"message":"[APM]](https://github.com/elastic/kibana/issues/145849\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145857","number":145857,"mergeCommit":{"message":"[APM]){kind=link}
\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab](https://github.com/elastic/kibana/issues/145849\r\n\r\nBefore\r\n\r\n\r\n\r\n\r\nAfter\r\n\r\n","sha":"40de9eb5e7c13b0c3596a37ee0c1d105dc6148ab){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #145849
Before
After
