Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Inspect modal styling issue #146015

Merged
merged 3 commits into from
Nov 23, 2022
Merged

[SecuritySolution] Inspect modal styling issue #146015

merged 3 commits into from
Nov 23, 2022

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Nov 22, 2022 •
edited by kibanamachine
Loading

Summary

Original issue: #145800
The size of inspect modal was not aligned between request and response.

Before:

Network.-.Kibana.Mozilla.Firefox.2022-11-21.11-58-53.mp4

After:

Screen.Recording.2022-11-22.at.16.09.10.mov

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.6.0 v8.7.0 labels Nov 22, 2022
@angorayc angorayc changed the title Issue/145800 [SecuritySolution] Inspect modal styling issue Nov 22, 2022
@angorayc angorayc marked this pull request as ready for review November 23, 2022 09:09
@angorayc angorayc requested review from a team as code owners November 23, 2022 09:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

machadoum
machadoum approved these changes Nov 23, 2022
View reviewed changes
...mmon/components/visualization_actions/lens_attributes/users/kpi_user_authentications_area.ts Outdated
@@ -15,7 +15,7 @@ export const kpiUserAuthenticationsAreaLensAttributes: LensAttributes = {
state: {
visualization: {
axisTitlesVisibilitySettings: {
x: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in sneaking into another PR hehehe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh! Sorry about that!!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.7MB 9.7MB +156.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 9934048 into elastic:main Nov 23, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 23, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2022
@angorayc
[SecuritySolution] Inspect modal styling issue (elastic#146015)
7486f06 
## Summary

Original issue: elastic#145800
The size of inspect modal was not aligned between request and response.

Before:

https://user-images.githubusercontent.com/59917825/202986017-fbce8d03-a9d8-46b6-a235-a7b1b6634f6c.mp4

After:

https://user-images.githubusercontent.com/6295984/203363965-b80f89fe-5456-4e89-bd99-567637b80735.mov
(cherry picked from commit 9934048)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@angorayc angorayc added the fixed label Nov 23, 2022
kibanamachine added a commit that referenced this pull request Nov 23, 2022
@kibanamachine @angorayc
[8.6] [SecuritySolution] Inspect modal styling issue (#146015) (#146137)
72710f0 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[SecuritySolution] Inspect modal styling issue
(#146015)](#146015)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2022-11-23T12:31:47Z","message":"[SecuritySolution]
Inspect modal styling issue (#146015)\n\n## Summary\r\n\r\nOriginal
issue: https://github.com/elastic/kibana/issues/145800\r\nThe size of
inspect modal was not aligned between request and
response.\r\n\r\nBefore:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/59917825/202986017-fbce8d03-a9d8-46b6-a235-a7b1b6634f6c.mp4\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/203363965-b80f89fe-5456-4e89-bd99-567637b80735.mov","sha":"99340486af49ba542e1df3891a4ee20d7a7977d2","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.6.0","v8.7.0"],"number":146015,"url":"https://github.com/elastic/kibana/pull/146015","mergeCommit":{"message":"[SecuritySolution]
Inspect modal styling issue (#146015)\n\n## Summary\r\n\r\nOriginal
issue: https://github.com/elastic/kibana/issues/145800\r\nThe size of
inspect modal was not aligned between request and
response.\r\n\r\nBefore:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/59917825/202986017-fbce8d03-a9d8-46b6-a235-a7b1b6634f6c.mp4\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/203363965-b80f89fe-5456-4e89-bd99-567637b80735.mov","sha":"99340486af49ba542e1df3891a4ee20d7a7977d2"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146015","number":146015,"mergeCommit":{"message":"[SecuritySolution]
Inspect modal styling issue (#146015)\n\n## Summary\r\n\r\nOriginal
issue: https://github.com/elastic/kibana/issues/145800\r\nThe size of
inspect modal was not aligned between request and
response.\r\n\r\nBefore:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/59917825/202986017-fbce8d03-a9d8-46b6-a235-a7b1b6634f6c.mp4\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://user-images.githubusercontent.com/6295984/203363965-b80f89fe-5456-4e89-bd99-567637b80735.mov","sha":"99340486af49ba542e1df3891a4ee20d7a7977d2"}}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
@angorayc angorayc mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience fixed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@angorayc @elasticmachine @kibana-ci @kibanamachine @machadoum