Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Inspect modal styling #147188

Closed
wants to merge 1 commit into from

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 7, 2022

Summary

Original issue: #145800
Previous fix: #146015
Previous fix missed to update the styles for x-pack/plugins/timelines/public/components/inspect/modal.tsx, so some of the inspect modal did not apply the same styling.

Steps to verify:

  • Please check the inspect panels for hosts page - events table, users page - events table and alerts page - alerts table. Please check the modals' hight and width are the same as rest of the inspect modals on the page.

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting:Explore v8.6.0 v8.7.0 labels Dec 7, 2022
@angorayc angorayc self-assigned this Dec 7, 2022
@angorayc angorayc closed this Dec 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 74.8KB 74.8KB +52.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants