[ML] Adds created_by job property for the advanced wizard #167021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:enhancement
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| @@ -240,7 +241,12 @@ export async function cloneJob(jobId) { | |||
| return; | |||
| } | |||
|
|
|||
| if (cloneableJob !== undefined && originalJob?.custom_settings?.created_by !== undefined) { | |||
| const createdBy = originalJob?.custom_settings?.created_by; | |||
There was a problem hiding this comment.
When I export jobs, looks like created_by is removed (tried an advanced job and a multi-metric one). I can't remember - was this intentional?
There was a problem hiding this comment.
We're using the flag exclude_generated: true when retrieving the jobs from es. This removes the created_by prop.
If we think it would be better to not strip this out, I can change it in a separate PR.
There was a problem hiding this comment.
Sounds a good idea to retain created_by on export, and to do it in a separate PR.
peteharverson
approved these changes
Sep 26, 2023
jgowdyelastic
added a commit
that referenced
this pull request
Sep 27, 2023
…167319) When exporting an anomaly detection job, it would be useful if the original `created_by` property was not removed from the job config. Related to #167021 (comment) Related PR #88898
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
created_byproperty ofadvanced-wizardto all jobs created by the advanced job wizard.Previously no
created_byproperty was added to these jobs.When cloning, jobs with no
created_byproperty or one with a value ofadvanced-wizardwill be opened in the advanced wizard.Closes #166053