Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Retains created_by setting when exporting anomaly detection jobs #167319

Merged

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 26, 2023

When exporting an anomaly detection job, it would be useful if the original created_by property was not removed from the job config.

Related to #167021 (comment)
Related PR #88898

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson changed the title [ML] Retain created_by when exporting AD jobs [ML] Retain created_by setting when exporting anomaly detection jobs Sep 27, 2023
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member

qn895 commented Sep 27, 2023

Code LGTM 🎉

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #22 / maps app mvt scaling "after all" hook in "mvt scaling"
  • [job] [logs] FTR Configs #22 / maps app mvt scaling filtering applyGlobalQuery: true, applyGlobalTime: true, applyForceRefresh: true "after all" hook for "should update MVT URL when refresh clicked"
  • [job] [logs] FTR Configs #22 / maps app mvt scaling filtering applyGlobalQuery: true, applyGlobalTime: true, applyForceRefresh: true should update MVT URL when refresh clicked

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +11.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 76.0KB 76.0KB +23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 354efc2 into elastic:main Sep 27, 2023
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 27, 2023
@jgowdyelastic jgowdyelastic deleted the retain-created_by-when-exporting-jobs branch September 27, 2023 17:45
@szabosteve szabosteve changed the title [ML] Retain created_by setting when exporting anomaly detection jobs [ML] Retains created_by setting when exporting anomaly detection jobs Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants