Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [Security Solution][Detection Engine] updates ES|QL info popover (#168611) #169203

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.11:

Questions ?

Please refer to the Backport tool documentation

…stic#168611)

## Summary

- addresses elastic/ux-writing#41
- content of info tooltip is moved to doc page. Instead only link to
that page is displayed

### Before

<img width="1459" alt="Screenshot 2023-10-13 at 15 56 20"
src="https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075">

### After

<img width="1298" alt="Screenshot 2023-10-13 at 15 53 07"
src="https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
(cherry picked from commit 761fa51)
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 18, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #6 / Response console document signing should fail if data tampered should fail if data tampered

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/doc-links 75 74 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 147.4KB 147.4KB +32.0B
securitySolution 13.0MB 13.0MB -1.2KB
total -1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 368.4KB 368.4KB +32.0B
Unknown metric groups

API count

id before after diff
@kbn/doc-links 75 74 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@kibanamachine kibanamachine merged commit 7003d55 into elastic:8.11 Oct 18, 2023
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants