Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [Security Solution][Detection Engine] updates ES|QL info popover (#168611) #169203

Merged
merged 2 commits into from
Oct 18, 2023

Commits on Oct 18, 2023

  1. [Security Solution][Detection Engine] updates ES|QL info popover (ela…

    …stic#168611)
    
    ## Summary
    
    - addresses elastic/ux-writing#41
    - content of info tooltip is moved to doc page. Instead only link to
    that page is displayed
    
    ### Before
    
    <img width="1459" alt="Screenshot 2023-10-13 at 15 56 20"
    src="https://github.com/elastic/kibana/assets/92328789/9a00ea01-19c1-4639-ad7b-9ae92829f075">
    
    ### After
    
    <img width="1298" alt="Screenshot 2023-10-13 at 15 53 07"
    src="https://github.com/elastic/kibana/assets/92328789/84811780-5d42-4ed3-b0d6-200467443e2f">
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [x]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    
    ---------
    
    Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
    (cherry picked from commit 761fa51)
    vitaliidm committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    13a623c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aed2f7f View commit details
    Browse the repository at this point in the history