[EuiInMemoryTable] Replace basic usages of deprecated ref method with controlled `selection.selected` API #175722

cee-chen · 2024-01-26T18:57:47Z

Summary

EUI will shortly be removing this deprecated ref setSelection method in favor of the new controlled selection.selected prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions.

Please help us QA your affected tables to confirm that your table selection still works as before!

elasticmachine · 2024-01-26T22:42:52Z

Pinging @elastic/eui-team (EUI)

jeramysoucy

LGTM! Just once change request for our team.

...gins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx

x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx

… controlled `selection.selected` API (#175727) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - #175722 (examples of basic conversions)

…ith controlled `selection.selected` API (#175838) Closes #175836 ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts the Security plugin's basic usages of controlled selection and additionally removes 2 deletion cancellation behaviors on the team's request. There should not be any other UI/UX regressions when selecting rows. See also: - elastic/eui#7321 - #175722 (examples of basic conversions)

cauemarcondes

LGTM

rshen91

tested locally in stateful

… method with controlled `selection.selected` API (#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - #175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>

adcoelho

Cases changes ok 👍

spong · 2024-01-31T15:57:46Z

x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx

Just tested locally and this appears to break the 'select all pages' action:

Before / After (changes from this PR):

cc @andrew-goldstein

I think this should fix it - please let me know if not! 1567fd9

… controlled `selection.selected` API (elastic#175727) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)

…cted` API

…cted` API + remove `refs` (should no longer be needed)

…ion.selected` API

andrew-goldstein · 2024-01-31T23:49:53Z

.../packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.test.tsx

-    expect(screen.getByTestId('selectedFields')).toHaveTextContent('Selected 2 fields');
+    // The select all button should select all rows regardless of visibility
+    userEvent.click(screen.getByTestId('selectAllFields'));
+    expect(screen.getByTestId('selectedFields')).toHaveTextContent('Selected 20 fields');


Thanks for adding this @cee-chen !

andrew-goldstein

Thanks for this update @cee-chen! 🙏
✅ Desk tested locally
LGTM 🚀

kibana-ci · 2024-01-31T23:56:14Z

💚 Build Succeeded

Buildkite Build
Commit: 1567fd9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	450.4KB	450.3KB	-102.0B
`infra`	1.3MB	1.3MB	-113.0B
`savedObjectsTagging`	46.5KB	46.4KB	-114.0B
`securitySolution`	11.4MB	11.4MB	-224.0B
total			-553.0B

History

💚 Build #190602 succeeded 7284be5
💛 Build #190012 was flaky 1e87a0c
💚 Build #189719 succeeded 825494f
💔 Build #189692 failed 29c3626

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… method with controlled `selection.selected` API (elastic#175726) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions) Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>

… controlled `selection.selected` API (elastic#175722) ## Summary See elastic/eui#7321 EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts basic usages of controlled selection, which should not suffer any UI/UX regressions. **Please help us QA your affected tables to confirm that your table selection still works as before!**

… controlled `selection.selected` API (elastic#175727) ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)

…ith controlled `selection.selected` API (elastic#175838) Closes elastic#175836 ## Summary **Please help us QA your affected tables to confirm that your plugin's table selection still works as before!** EUI will shortly be removing this deprecated ref `setSelection` method in favor of the new controlled `selection.selected` prop. This PR converts the Security plugin's basic usages of controlled selection and additionally removes 2 deletion cancellation behaviors on the team's request. There should not be any other UI/UX regressions when selecting rows. See also: - elastic/eui#7321 - elastic#175722 (examples of basic conversions)