Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with controlled selection.selected API #175727

Merged
merged 2 commits into from
Jan 29, 2024
Merged

[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with controlled selection.selected API #175727

merged 2 commits into from
Jan 29, 2024

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Jan 26, 2024 •
edited
Loading

Summary

Please help us QA your affected tables to confirm that your plugin's table selection still works as before!

EUI will shortly be removing this deprecated ref setSelection method in favor of the new controlled selection.selected prop. This PR converts Fleet's more advanced usage of controlled selection, which should not suffer any UI/UX regressions.

See also:

@cee-chen
Copy link
Member Author

/ci

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.13.0 labels Jan 26, 2024
@cee-chen cee-chen mentioned this pull request Jan 26, 2024
Merged
4 tasks
@cee-chen cee-chen marked this pull request as ready for review January 26, 2024 21:33
@cee-chen cee-chen requested a review from a team as a code owner January 26, 2024 21:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB -93.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpollich kpollich self-requested a review January 29, 2024 22:04
kpollich
kpollich approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick smoke test of the agent table with a few enrolled agents looked good to me. All filters, selections, etc worked as expected. Thanks for pushing this change! 🚀

@cee-chen
Copy link
Member Author

Woohoo! Thank you Kyle! 🎉

@cee-chen cee-chen merged commit da17447 into elastic:main Jan 29, 2024
20 checks passed
@cee-chen cee-chen deleted the eui-table-selection-controlled-advanced branch January 29, 2024 22:34
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 29, 2024
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 31, 2024
@cee-chen @nreese
[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with…
bd9961d 
… controlled `selection.selected` API (elastic#175727)

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts Fleet's more advanced usage of controlled selection, which
should not suffer any UI/UX regressions.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Feb 6, 2024
@cee-chen @WafaaNasr
[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with…
98e6ec6 
… controlled `selection.selected` API (elastic#175727)

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts Fleet's more advanced usage of controlled selection, which
should not suffer any UI/UX regressions.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@cee-chen @CoenWarmer
[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with…
9e8c240 
… controlled `selection.selected` API (elastic#175727)

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts Fleet's more advanced usage of controlled selection, which
should not suffer any UI/UX regressions.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@cee-chen @CoenWarmer
[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with…
f20a218 
… controlled `selection.selected` API (elastic#175727)

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts Fleet's more advanced usage of controlled selection, which
should not suffer any UI/UX regressions.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@cee-chen @fkanout
[Fleet][EuiInMemoryTable] Replace usage of deprecated ref method with…
222d39b 
… controlled `selection.selected` API (elastic#175727)

## Summary

**Please help us QA your affected tables to confirm that your plugin's
table selection still works as before!**

EUI will shortly be removing this deprecated ref `setSelection` method
in favor of the new controlled `selection.selected` prop. This PR
converts Fleet's more advanced usage of controlled selection, which
should not suffer any UI/UX regressions.

See also: 
- elastic/eui#7321
- elastic#175722 (examples of basic
conversions)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cee-chen @elasticmachine @kibana-ci @kpollich @kibanamachine