Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/OAS] Support deprecated field #181240

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Apr 19, 2024

Summary

Adds a new field to @kbn/config-schema meta: deprecated. Also update the OAS script to add this field to the outputted OAS.

@jloleysens jloleysens added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Apr 19, 2024
@jloleysens jloleysens self-assigned this Apr 19, 2024
@jloleysens jloleysens force-pushed the http-oas/support-deprecated-field branch from 80ecb45 to 7a1222d Compare April 19, 2024 13:23
@jloleysens
Copy link
Contributor Author

/ci

@jloleysens jloleysens marked this pull request as ready for review April 22, 2024 09:14
@jloleysens jloleysens requested a review from a team as a code owner April 22, 2024 09:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@jloleysens jloleysens changed the title [HTTP/OAS] Support deprecated field [HTTP/OAS] Support deprecated field Apr 22, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +47.0B
serverlessSearch 455.3KB 455.4KB +47.0B
synthetics 1.0MB 1.0MB +91.0B
total +185.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jloleysens

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens jloleysens merged commit 0547800 into elastic:main Apr 24, 2024
16 checks passed
@jloleysens jloleysens deleted the http-oas/support-deprecated-field branch April 24, 2024 14:09
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 24, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 24, 2024
…1582)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[HTTP/OAS] Support `deprecated` field
(#181240)](#181240)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-04-24T14:09:46Z","message":"[HTTP/OAS]
Support `deprecated` field
(#181240)","sha":"05478009c69f5993207f8db1f93f1230f4006a96","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v8.14.0","v8.15.0"],"title":"[HTTP/OAS]
Support `deprecated`
field","number":181240,"url":"https://github.com/elastic/kibana/pull/181240","mergeCommit":{"message":"[HTTP/OAS]
Support `deprecated` field
(#181240)","sha":"05478009c69f5993207f8db1f93f1230f4006a96"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181240","number":181240,"mergeCommit":{"message":"[HTTP/OAS]
Support `deprecated` field
(#181240)","sha":"05478009c69f5993207f8db1f93f1230f4006a96"}}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <jeanlouis.leysens@elastic.co>
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:http release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants