Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OAS][DOCS] Deprecate saved object APIs #189223

Merged
merged 7 commits into from
Jul 31, 2024
Merged

[OAS][DOCS] Deprecate saved object APIs #189223

merged 7 commits into from
Jul 31, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 25, 2024 •
edited by kibanamachine
Loading

Summary

This pull request:

@lcawl lcawl added Feature:Saved Objects docs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS labels Jul 25, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review July 25, 2024 21:09
@lcawl lcawl requested review from a team as code owners July 25, 2024 21:09
@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Jul 25, 2024
TinaHeiligers
TinaHeiligers requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a description for export (public)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner July 26, 2024 16:26
@lcawl
Copy link
Contributor Author

lcawl commented Jul 26, 2024

We also need a description for export (public)

Good point! I've synched the text in the code and the manually-maintained OpenAPI document in d52682e

TinaHeiligers
TinaHeiligers approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl mentioned this pull request Jul 26, 2024
Merged
karenzone
karenzone approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

azasypkin
azasypkin approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in x-pack/plugins/encrypted_saved_objects/server/routes/key_rotation LGTM, thanks!

@lcawl lcawl enabled auto-merge (squash) July 30, 2024 23:16
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit e4a0658 into elastic:main Jul 31, 2024
19 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- [DOCS][OAS] Add alerting to Kibana API bundle (#188885)
- [DOCS][OAS] Add cases to Kibana API bundle (#189020)
- [OAS][DOCS] Remove some SLO APIs from OpenAPI documents (#189323)
- [HTTP/OAS] Add tags and summaries for saved object APIs (#184184)

Manual backport

To create the backport manually run:

node scripts/backport --pr 189223

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the saved-object-apis2 branch July 31, 2024 16:01
lcawl added a commit to lcawl/kibana that referenced this pull request Jul 31, 2024
@lcawl
[OAS][DOCS] Deprecate saved object APIs (elastic#189223)
349fb06 
(cherry picked from commit e4a0658)
@lcawl lcawl mentioned this pull request Jul 31, 2024
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Jul 31, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 1, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

lcawl added a commit that referenced this pull request Aug 2, 2024
@lcawl
[8.15] [OAS][DOCS] Deprecate saved object APIs (#189223) (#189655)
7eba0a1 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[OAS][DOCS] Deprecate saved object APIs
(#189223)](#189223)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2024-07-31T02:38:04Z","message":"[OAS][DOCS]
Deprecate saved object APIs
(#189223)","sha":"e4a06582258bd53927bfe159485a186ebce5b0d0","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Saved
Objects","release_note:skip","docs","backport:prev-minor","Feature:OAS","v8.16.0"],"number":189223,"url":"https://github.com/elastic/kibana/pull/189223","mergeCommit":{"message":"[OAS][DOCS]
Deprecate saved object APIs
(#189223)","sha":"e4a06582258bd53927bfe159485a186ebce5b0d0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189223","number":189223,"mergeCommit":{"message":"[OAS][DOCS]
Deprecate saved object APIs
(#189223)","sha":"e4a06582258bd53927bfe159485a186ebce5b0d0"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.15.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:OAS Work or issues related to Core-provided mechanisms for generating OAS Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lcawl @obltmachine @kibana-ci @kibanamachine @azasypkin @TinaHeiligers @karenzone