[Stateful sidenav] Update stack management landing page #191735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
sebelga
force-pushed
the
stateful-sidenav/management-landing-page
branch
2 times, most recently
from
e6f9830
to
92f993b
Compare
|
/ci |
3 similar comments
|
/ci |
|
/ci |
|
/ci |
sebelga
force-pushed
the
stateful-sidenav/management-landing-page
branch
from
df4ea50
to
c059a5b
Compare
|
/ci |
…trol the selected node
sebelga
force-pushed
the
stateful-sidenav/management-landing-page
branch
from
c059a5b
to
1af2486
Compare
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
joemcelroy
approved these changes
Sep 23, 2024
sabarasaba
approved these changes
Sep 23, 2024
|
@sebelga Code LGTM, but I cant remember how to get the new Nav to show up 😅 Can you remind me? |
@kc13greiner you need to add the following in the xpack.spaces.experimental.forceSolutionVisibility: trueAnd then create a space with the solution you want. |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: cc @sebelga |
eokoneyo
reviewed
Sep 24, 2024
Comment on lines
+72
to
+76
| <FormattedMessage | ||
| id="management.landing.solution.header" | ||
| defaultMessage="Stack Management {version}" | ||
| values={{ version: kibanaVersion }} | ||
| /> |
There was a problem hiding this comment.
Should we exclude kibana version particularly for serverless projects, to be in line with the direction we've taken for other instances where kibana version previously would get displayed?
There was a problem hiding this comment.
The empty prompt is not shown in serverless. In serverless we display the management cards.
eokoneyo
approved these changes
Sep 24, 2024
|
Thanks for the review @eokoneyo ! |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit 92f1320)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
… (#193867) # Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Update stack management landing page (#191735)](#191735) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-09-24T13:01:02Z","message":"[Stateful sidenav] Update stack management landing page (#191735)","sha":"92f13200194e2faf35aa95a21e95d39323b2e824","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Stateful sidenav] Update stack management landing page","number":191735,"url":"https://github.com/elastic/kibana/pull/191735","mergeCommit":{"message":"[Stateful sidenav] Update stack management landing page (#191735)","sha":"92f13200194e2faf35aa95a21e95d39323b2e824"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191735","number":191735,"mergeCommit":{"message":"[Stateful sidenav] Update stack management landing page (#191735)","sha":"92f13200194e2faf35aa95a21e95d39323b2e824"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
neptunian
pushed a commit
to neptunian/kibana
that referenced
this pull request
Oct 1, 2024
…c#191735) (elastic#193867) # Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Update stack management landing page (elastic#191735)](elastic#191735) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-09-24T13:01:02Z","message":"[Stateful sidenav] Update stack management landing page (elastic#191735)","sha":"92f13200194e2faf35aa95a21e95d39323b2e824","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Stateful sidenav] Update stack management landing page","number":191735,"url":"https://github.com/elastic/kibana/pull/191735","mergeCommit":{"message":"[Stateful sidenav] Update stack management landing page (elastic#191735)","sha":"92f13200194e2faf35aa95a21e95d39323b2e824"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191735","number":191735,"mergeCommit":{"message":"[Stateful sidenav] Update stack management landing page (elastic#191735)","sha":"92f13200194e2faf35aa95a21e95d39323b2e824"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
semd
added a commit
that referenced
this pull request
Oct 2, 2024
## Summary Since the Stack Management landing page [has been dropped](#191735) in the new "Solution navigation" in stateful (ESS) environments, we need to include some of the missing Security Solution links in the left navigation flyout panel. The PR also contains the removal of the "Recent" section from the left navigation, this is a SecuritySolution-specific product/design decision. #### Adding the missing links to the Stack Management left navigation panel flyout - Entity Risk Score (Alerts and Insights) - Asset Criticality (Alerts and Insights) - Graph (Kibana) - Canvas (Kibana) - Map (Kibana) - Visualiztion Library (Kibana)   #### Removing the "Recent" links item from the navigation. Before <img width="277" alt="old" src="https://github.com/user-attachments/assets/0eaccd3c-04e9-4838-bae9-e44e4fa0cec9"> After <img width="277" alt="Captura de pantalla 2024-10-02 a les 13 32 55" src="https://github.com/user-attachments/assets/53266f93-de2b-4d31-9935-5a793b6c99e8"> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 2, 2024
…4384) ## Summary Since the Stack Management landing page [has been dropped](elastic#191735) in the new "Solution navigation" in stateful (ESS) environments, we need to include some of the missing Security Solution links in the left navigation flyout panel. The PR also contains the removal of the "Recent" section from the left navigation, this is a SecuritySolution-specific product/design decision. #### Adding the missing links to the Stack Management left navigation panel flyout - Entity Risk Score (Alerts and Insights) - Asset Criticality (Alerts and Insights) - Graph (Kibana) - Canvas (Kibana) - Map (Kibana) - Visualiztion Library (Kibana)   #### Removing the "Recent" links item from the navigation. Before <img width="277" alt="old" src="https://github.com/user-attachments/assets/0eaccd3c-04e9-4838-bae9-e44e4fa0cec9"> After <img width="277" alt="Captura de pantalla 2024-10-02 a les 13 32 55" src="https://github.com/user-attachments/assets/53266f93-de2b-4d31-9935-5a793b6c99e8"> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4da439d)
kibanamachine
added a commit
that referenced
this pull request
Oct 2, 2024
) (#194720) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution] Stateful new solution nav improvements (#194384)](#194384) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-10-02T14:45:38Z","message":"[SecuritySolution] Stateful new solution nav improvements (#194384)\n\n## Summary\r\n\r\nSince the Stack Management landing page [has been\r\ndropped](#191735) in the new\r\n\"Solution navigation\" in stateful (ESS) environments, we need to include\r\nsome of the missing Security Solution links in the left navigation\r\nflyout panel.\r\n\r\nThe PR also contains the removal of the \"Recent\" section from the left\r\nnavigation, this is a SecuritySolution-specific product/design decision.\r\n\r\n#### Adding the missing links to the Stack Management left navigation\r\npanel flyout\r\n\r\n- Entity Risk Score (Alerts and Insights)\r\n- Asset Criticality (Alerts and Insights)\r\n- Graph (Kibana)\r\n- Canvas (Kibana)\r\n- Map (Kibana)\r\n- Visualiztion Library (Kibana)\r\n\r\n\r\n\r\n\r\n\r\n\r\n#### Removing the \"Recent\" links item from the navigation.\r\n\r\nBefore\r\n<img width=\"277\" alt=\"old\"\r\nsrc=\"https://github.com/user-attachments/assets/0eaccd3c-04e9-4838-bae9-e44e4fa0cec9\">\r\n\r\nAfter\r\n<img width=\"277\" alt=\"Captura de pantalla 2024-10-02 a les 13 32 55\"\r\nsrc=\"https://github.com/user-attachments/assets/53266f93-de2b-4d31-9935-5a793b6c99e8\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4da439df876ffa148b33f82c1acc6b725b37829e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","v8.16.0"],"title":"[SecuritySolution] Stateful new solution nav improvements","number":194384,"url":"https://github.com/elastic/kibana/pull/194384","mergeCommit":{"message":"[SecuritySolution] Stateful new solution nav improvements (#194384)\n\n## Summary\r\n\r\nSince the Stack Management landing page [has been\r\ndropped](#191735) in the new\r\n\"Solution navigation\" in stateful (ESS) environments, we need to include\r\nsome of the missing Security Solution links in the left navigation\r\nflyout panel.\r\n\r\nThe PR also contains the removal of the \"Recent\" section from the left\r\nnavigation, this is a SecuritySolution-specific product/design decision.\r\n\r\n#### Adding the missing links to the Stack Management left navigation\r\npanel flyout\r\n\r\n- Entity Risk Score (Alerts and Insights)\r\n- Asset Criticality (Alerts and Insights)\r\n- Graph (Kibana)\r\n- Canvas (Kibana)\r\n- Map (Kibana)\r\n- Visualiztion Library (Kibana)\r\n\r\n\r\n\r\n\r\n\r\n\r\n#### Removing the \"Recent\" links item from the navigation.\r\n\r\nBefore\r\n<img width=\"277\" alt=\"old\"\r\nsrc=\"https://github.com/user-attachments/assets/0eaccd3c-04e9-4838-bae9-e44e4fa0cec9\">\r\n\r\nAfter\r\n<img width=\"277\" alt=\"Captura de pantalla 2024-10-02 a les 13 32 55\"\r\nsrc=\"https://github.com/user-attachments/assets/53266f93-de2b-4d31-9935-5a793b6c99e8\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4da439df876ffa148b33f82c1acc6b725b37829e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194384","number":194384,"mergeCommit":{"message":"[SecuritySolution] Stateful new solution nav improvements (#194384)\n\n## Summary\r\n\r\nSince the Stack Management landing page [has been\r\ndropped](#191735) in the new\r\n\"Solution navigation\" in stateful (ESS) environments, we need to include\r\nsome of the missing Security Solution links in the left navigation\r\nflyout panel.\r\n\r\nThe PR also contains the removal of the \"Recent\" section from the left\r\nnavigation, this is a SecuritySolution-specific product/design decision.\r\n\r\n#### Adding the missing links to the Stack Management left navigation\r\npanel flyout\r\n\r\n- Entity Risk Score (Alerts and Insights)\r\n- Asset Criticality (Alerts and Insights)\r\n- Graph (Kibana)\r\n- Canvas (Kibana)\r\n- Map (Kibana)\r\n- Visualiztion Library (Kibana)\r\n\r\n\r\n\r\n\r\n\r\n\r\n#### Removing the \"Recent\" links item from the navigation.\r\n\r\nBefore\r\n<img width=\"277\" alt=\"old\"\r\nsrc=\"https://github.com/user-attachments/assets/0eaccd3c-04e9-4838-bae9-e44e4fa0cec9\">\r\n\r\nAfter\r\n<img width=\"277\" alt=\"Captura de pantalla 2024-10-02 a les 13 32 55\"\r\nsrc=\"https://github.com/user-attachments/assets/53266f93-de2b-4d31-9935-5a793b6c99e8\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"4da439df876ffa148b33f82c1acc6b725b37829e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've removed the management cards in the stack management landing page and used the classic landing page.
This changes applies to all 3 solutions, only for the new side navigation in stateful.
Fixes https://github.com/elastic/kibana-team/issues/1063
Screenshots