[Stateful sidenav] Fix side nav panel clipping #194268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
reviewed
Sep 27, 2024
packages/core/chrome/core-chrome-browser-internal/src/ui/project/navigation.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the review @Dosant ! Can you have another look? cheers 👍 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @sebelga |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11073552121 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2024
(cherry picked from commit c01de8c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Fix side nav panel clipping (#194268)](#194268) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-09-27T15:37:36Z","message":"[Stateful sidenav] Fix side nav panel clipping (#194268)","sha":"c01de8cf4db64d91c42f0170587f5f648c26fb3f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Chrome"],"title":"[Stateful sidenav] Fix side nav panel clipping","number":194268,"url":"https://github.com/elastic/kibana/pull/194268","mergeCommit":{"message":"[Stateful sidenav] Fix side nav panel clipping (#194268)","sha":"c01de8cf4db64d91c42f0170587f5f648c26fb3f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194268","number":194268,"mergeCommit":{"message":"[Stateful sidenav] Fix side nav panel clipping (#194268)","sha":"c01de8cf4db64d91c42f0170587f5f648c26fb3f"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
angorayc
pushed a commit
to angorayc/kibana
that referenced
this pull request
Oct 1, 2024
neptunian
pushed a commit
to neptunian/kibana
that referenced
this pull request
Oct 1, 2024
…elastic#194318) # Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Fix side nav panel clipping (elastic#194268)](elastic#194268) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-09-27T15:37:36Z","message":"[Stateful sidenav] Fix side nav panel clipping (elastic#194268)","sha":"c01de8cf4db64d91c42f0170587f5f648c26fb3f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor","Feature:Chrome"],"title":"[Stateful sidenav] Fix side nav panel clipping","number":194268,"url":"https://github.com/elastic/kibana/pull/194268","mergeCommit":{"message":"[Stateful sidenav] Fix side nav panel clipping (elastic#194268)","sha":"c01de8cf4db64d91c42f0170587f5f648c26fb3f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194268","number":194268,"mergeCommit":{"message":"[Stateful sidenav] Fix side nav panel clipping (elastic#194268)","sha":"c01de8cf4db64d91c42f0170587f5f648c26fb3f"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
seanrathier
pushed a commit
to seanrathier/kibana
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've fixed a bug in the side nav panel that was clipped when the side nav was collapsed.
In #191735 we allowed opening the panel from inside the stack management landing page. I didn't take into consideration that the side nav could be collapsed. This PR fixes it.
Screenshots
Before
After