Upgrade EUI to v97.0.0 #195525
Merged
Upgrade EUI to v97.0.0 #195525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
6 tasks
…ity timeline table
… no longer has text - text is now entirely SR only
|
Pinging @elastic/eui-team (EUI) |
markov00
approved these changes
Oct 10, 2024
|
We're experiencing some CI flakiness. I confirmed that none of these test failures are caused by the changes in this PR |
umbopepato
approved these changes
Oct 11, 2024
patrykkopycinski
approved these changes
Oct 11, 2024
nickpeihl
approved these changes
Oct 11, 2024
nkhristinin
approved these changes
Oct 14, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
tomsonpl
approved these changes
Oct 14, 2024
szwarckonrad
approved these changes
Oct 14, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11326723307 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
`v96.1.0`⏩`v97.0.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0) **Breaking changes** - EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`) no longer automatically renders the column header row or footer rows. It instead now passes the `headerRow` and `footerRow` React elements, which require manual rendering. ([elastic#8028](elastic/eui#8028)) - This change was made to allow consumers to sync header/footer rows with their own custom virtualization libraries. - To facilitate this, a `gridWidth` prop is now also passed to custom grid body renderers. **Bug fixes** - Fixed inputs not taking the whole width when passing `fullWidth` as `true` to EuiDatePickerRange component ([elastic#8061](elastic/eui#8061)) **Accessibility** - Improved accessibility of `EuiExternalLinkIcon` by clarifying text for Screen Reader users. ([elastic#8065](elastic/eui#8065)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit cd60c66)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Upgrade EUI to v97.0.0 (#195525)](#195525) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-14T11:35:35Z","message":"Upgrade EUI to v97.0.0 (#195525)\n\n`v96.1.0`⏩`v97.0.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0)\r\n\r\n**Breaking changes**\r\n\r\n- EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`)\r\nno longer automatically renders the column header row or footer rows. It\r\ninstead now passes the `headerRow` and `footerRow` React elements, which\r\nrequire manual rendering.\r\n([#8028](https://github.com/elastic/eui/pull/8028))\r\n- This change was made to allow consumers to sync header/footer rows\r\nwith their own custom virtualization libraries.\r\n- To facilitate this, a `gridWidth` prop is now also passed to custom\r\ngrid body renderers.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed inputs not taking the whole width when passing `fullWidth` as\r\n`true` to EuiDatePickerRange component\r\n([#8061](https://github.com/elastic/eui/pull/8061))\r\n\r\n**Accessibility**\r\n\r\n- Improved accessibility of `EuiExternalLinkIcon` by clarifying text for\r\nScreen Reader users. ([#8065](https://github.com/elastic/eui/pull/8065))\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"cd60c66d19ffdb4130a5c2d1b76e80cfaf8cde78","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","release_note:skip","EUI","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0","backport:version"],"title":"Upgrade EUI to v97.0.0","number":195525,"url":"https://github.com/elastic/kibana/pull/195525","mergeCommit":{"message":"Upgrade EUI to v97.0.0 (#195525)\n\n`v96.1.0`⏩`v97.0.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0)\r\n\r\n**Breaking changes**\r\n\r\n- EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`)\r\nno longer automatically renders the column header row or footer rows. It\r\ninstead now passes the `headerRow` and `footerRow` React elements, which\r\nrequire manual rendering.\r\n([#8028](https://github.com/elastic/eui/pull/8028))\r\n- This change was made to allow consumers to sync header/footer rows\r\nwith their own custom virtualization libraries.\r\n- To facilitate this, a `gridWidth` prop is now also passed to custom\r\ngrid body renderers.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed inputs not taking the whole width when passing `fullWidth` as\r\n`true` to EuiDatePickerRange component\r\n([#8061](https://github.com/elastic/eui/pull/8061))\r\n\r\n**Accessibility**\r\n\r\n- Improved accessibility of `EuiExternalLinkIcon` by clarifying text for\r\nScreen Reader users. ([#8065](https://github.com/elastic/eui/pull/8065))\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"cd60c66d19ffdb4130a5c2d1b76e80cfaf8cde78"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195525","number":195525,"mergeCommit":{"message":"Upgrade EUI to v97.0.0 (#195525)\n\n`v96.1.0`⏩`v97.0.0`\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v97.0.0`](https://github.com/elastic/eui/releases/v97.0.0)\r\n\r\n**Breaking changes**\r\n\r\n- EuiDataGrid's custom grid body (rendered via `renderCustomGridBody`)\r\nno longer automatically renders the column header row or footer rows. It\r\ninstead now passes the `headerRow` and `footerRow` React elements, which\r\nrequire manual rendering.\r\n([#8028](https://github.com/elastic/eui/pull/8028))\r\n- This change was made to allow consumers to sync header/footer rows\r\nwith their own custom virtualization libraries.\r\n- To facilitate this, a `gridWidth` prop is now also passed to custom\r\ngrid body renderers.\r\n\r\n**Bug fixes**\r\n\r\n- Fixed inputs not taking the whole width when passing `fullWidth` as\r\n`true` to EuiDatePickerRange component\r\n([#8061](https://github.com/elastic/eui/pull/8061))\r\n\r\n**Accessibility**\r\n\r\n- Improved accessibility of `EuiExternalLinkIcon` by clarifying text for\r\nScreen Reader users. ([#8065](https://github.com/elastic/eui/pull/8065))\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"cd60c66d19ffdb4130a5c2d1b76e80cfaf8cde78"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
maximpn
added a commit
that referenced
this pull request
Oct 16, 2024
…6309) ## Summary This PR generalizes external link text cleanup in `removeExternalLinkText`. ## Details Recent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
…stic#196309) ## Summary This PR generalizes external link text cleanup in `removeExternalLinkText`. ## Details Recent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back elastic#195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way. (cherry picked from commit daf4aae)
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
#196309) (#196502) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Clean up external link text in a general way (#196309)](#196309) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2024-10-16T09:00:18Z","message":"[Security Solution] Clean up external link text in a general way (#196309)\n\n## Summary\r\n\r\nThis PR generalizes external link text cleanup in `removeExternalLinkText`. \r\n\r\n## Details\r\n\r\nRecent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.","sha":"daf4aae6aa202fd1148beea269939090137b659a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","backport:prev-minor","v8.17.0"],"title":"[Security Solution] Clean up external link text in a general way","number":196309,"url":"https://github.com/elastic/kibana/pull/196309","mergeCommit":{"message":"[Security Solution] Clean up external link text in a general way (#196309)\n\n## Summary\r\n\r\nThis PR generalizes external link text cleanup in `removeExternalLinkText`. \r\n\r\n## Details\r\n\r\nRecent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.","sha":"daf4aae6aa202fd1148beea269939090137b659a"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196309","number":196309,"mergeCommit":{"message":"[Security Solution] Clean up external link text in a general way (#196309)\n\n## Summary\r\n\r\nThis PR generalizes external link text cleanup in `removeExternalLinkText`. \r\n\r\n## Details\r\n\r\nRecent Rule Management [periodic pipeline failure](https://buildkite.com/elastic/security-serverless-quality-gate-kibana-periodic/builds/1209#job-01928e56-28f3-4b45-8f9f-7158b324c115) was caused by merging back #195525. Despite EUI changes were [addressed](https://github.com/elastic/kibana/pull/195525/files#diff-8d47b006a91beb2c5074560dbcd42eecef96173e03ffeec7c726dd322425f760) in our test utility it wasn't properly picked up. The problem is fixed in a more general way.","sha":"daf4aae6aa202fd1148beea269939090137b659a"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v96.1.0⏩v97.0.0Questions? Please see our Kibana upgrade FAQ.
v97.0.0Breaking changes
renderCustomGridBody) no longer automatically renders the column header row or footer rows. It instead now passes theheaderRowandfooterRowReact elements, which require manual rendering. (#8028)gridWidthprop is now also passed to custom grid body renderers.Bug fixes
fullWidthastrueto EuiDatePickerRange component (#8061)Accessibility
EuiExternalLinkIconby clarifying text for Screen Reader users. (#8065)