[Security Solution][Alert details] - fix failing Cypress test on MKI #196578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
backport
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
christineweng
approved these changes
Oct 16, 2024
PhilippeOberti
force-pushed
the
fix-flyout-cypress-mki
branch
from
afa72af
to
76fb6e1
Compare
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11373923932 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 16, 2024
…lastic#196578) (cherry picked from commit 0c37342)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 16, 2024
…n MKI (#196578) (#196611) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Alert details] - fix failing Cypress test on MKI (#196578)](#196578) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-16T21:10:51Z","message":"[Security Solution][Alert details] - fix failing Cypress test on MKI (#196578)","sha":"0c37342389505a58f13c94a0f385da2cbb9d50ce","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Alert details] - fix failing Cypress test on MKI","number":196578,"url":"https://github.com/elastic/kibana/pull/196578","mergeCommit":{"message":"[Security Solution][Alert details] - fix failing Cypress test on MKI (#196578)","sha":"0c37342389505a58f13c94a0f385da2cbb9d50ce"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196578","number":196578,"mergeCommit":{"message":"[Security Solution][Alert details] - fix failing Cypress test on MKI (#196578)","sha":"0c37342389505a58f13c94a0f385da2cbb9d50ce"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent EUI PR made a change to one or our NO_DATA_MESSAGE value (here) and since then a Cypress test has been failing on MKI (see this failure). I am not sure why this test works fine locally, in normal CI but not on MKI...
Ultimately, the Cypress test in question doesn't need to check for a text value (this is actually not good practice). This PR replaces the check for a specific text by the existence of the DOM element that renders that text. On top of that, we are already testing the text in a Jest unit test here for session view and here for response, so this was redundant.
This PR skips one timeline notes test as I'm not familiar with how this test works and is supposed to test...
Checklist