Timefilter Auto Refresh - Closes "Support for auto-refresh #1845" #2196

grouma · 2014-12-09T20:50:27Z

Fixes #1845 - Support for auto-refresh
Fixes #1778 - Courier race condition
Fixes #2365 - Respect shard_timeout config
Fixes #2420 - Visualization disappears in discover

Feature:
Enable auto-refresh of the various built in tabs, e.g. Discover, Visualize and Dashboard. The implementation should allow future plugins to respond to refresh events.

Usage:
Upon clicking the top right corner, you will be presented with two tabs, "Time Filter" and "Refresh Interval" (see attached image for details). The "Time Filter" tab allows users to add time filters in the same capacity as they are today. The new "Refresh Interval" tab allows users to select a predefined refresh interval. Upon selecting a refresh interval, all tabs will automatically refresh their content.

Implementation:
The feature was implemented by piggy-backing on top of the existing timefilter object. The timefilter object now contains a refreshInterval. The courier now receives reference to the timefilter object and listens for changes on this refreshInterval. It updates the search interval accordingly.

merge master
search requests that don't complete before the refresh interval is triggered again should delay the next trigger until they are complete. (pretty sure this will require some dev)
verify that requests/searchSources are never duplicated
choosing "auto refresh off" should not trigger another request
refresh interval should be saved in sessionStorage so that it persists across refreshes, but is issolated from other tabs and won't be shared in urls
Give love to list of refresh options.

rashidkpc · 2014-12-09T21:42:42Z

The applications shouldn't need individual refresh handlers, rather the courier should just reget the data and the applications should react to it.

Also, this has windows build system changes merged into that are outside the scope of the issue.

grouma · 2014-12-09T22:13:56Z

I agree that making use of the courier class will simplify things. Let me make those changes.

grouma · 2014-12-09T23:53:27Z

I have removed the windows build system changes and have updated the implementation to make use of the courier class.

rashidkpc · 2014-12-11T18:26:48Z

Had a quick look over, can you add tests for this?

grouma · 2014-12-11T19:50:41Z

Tests added.

spalger · 2014-12-12T21:34:25Z

src/kibana/plugins/kibana/kibana.html

@@ -18,7 +18,7 @@
      <!-- Full navbar -->
      <div collapse="!showCollapsed" class="navbar-collapse" id="kibana-primary-navbar">
        <ul class="nav navbar-nav">
-          <li ng-repeat="app in apps.inOrder | filter:{show: true}" ng-class="{active: activeApp === app}">


The | filter: {show: true} needs to stay in there

spalger · 2014-12-12T21:41:08Z

@grouma thanks for the PR! I left a couple notes

…cking.

grouma · 2014-12-15T20:51:34Z

@spenceralger all open issues should be addressed in most recent commit. Let me know if you need any other changes.

spalger · 2014-12-15T21:24:16Z

@grouma sweet, could you do us a favor and merge master?

grouma · 2014-12-15T21:59:49Z

Looks like you already took care of it. Thanks.

w33ble · 2014-12-15T22:32:10Z

@grouma nice work on this, it's a pretty cool addition!

We've got some comment in @spenceralger's PR #2324. We had hoped we could get this in the next release, but it appears that's happening a little too soon - we might bring the comments back here, especially if you want to keep helping out with it. Just trying to figure out how to proceed.

grouma · 2014-12-15T22:43:05Z

@w33ble Let's bring it back here and I'll address the issues.

spalger · 2014-12-15T22:43:45Z

@grouma, I was hoping we would be able to get this into beta 3 (which we plan to release tomorrow). After discussing it with the team though, we all agree that has the potential to include bugs we don't really have the time to prove don't exist before then. Since we aren't trying to rush this in anymore, I'm going to close my issue and we will continue development here.

Off the top of my head, these are a few things we need to resolve:

merge master
search requests that don't complete before the refresh interval is triggered again should delay the next trigger until they are complete. (pretty sure this will require some dev)
verify that requests/searchSources are never duplicated
choosing "auto refresh off" should not trigger another request

… TimefilterAutoRefresh Conflicts: src/kibana/components/timepicker/timepicker.html

grouma · 2014-12-16T02:12:44Z

@spenceralger I have merged the master and prevented the "off" interval from triggering another request. I am unsure how to address the other two issues since the Discover plugin provides a custom "fetch" function. I would like to leverage the logic already provided in the courier component. Any guidance would be appreciated.

spalger · 2014-12-16T05:34:26Z

Sweet, if you can work on verifying the courier based requests in visualize and dashboard and I'll work on moving discovers segmented fetch into a courier search strategy. I've been meaning to do that anyway.

…ir requests

… segment_in_courier

… TimefilterAutoRefresh

simianhacker · 2014-12-30T00:10:29Z

Add issue for throbber and sorting and LGTM

…only emit segments with rows

spalger · 2014-12-30T02:19:07Z

Added issue for sorting, but handled throbber really quick.

Timefilter Auto Refresh - Closes "Support for auto-refresh #1845"

spalger · 2014-12-30T02:21:25Z

@grouma that turned out to be a pretty epic pr. THANK YOU SO MUCH! This is a huge enhancement for K4.

If you're every in Phoenix let us buy you a beer 🍻

grouma · 2015-01-01T17:10:32Z

@spenceralger I agree! I thought it would be a small feature to get acquainted with the codebase. Sorry for fizzling out with the help near the end as the holidays took priority ;)

If you are ever in Seattle the same offer is there for you

w33ble · 2015-01-05T21:23:48Z

@grouma @spenceralger you guys killed it - this is a great feature that really came together. Nice work!

And @grouma, thanks so much for contributing, and for being patient with us ;)

Blevene · 2015-02-05T16:48:08Z

Was this implemented in Beta 3 from the main site (http://www.elasticsearch.org/overview/kibana/installation/)? I currently do not have the Time Filter "Refresh" Tab.

grouma · 2015-02-05T20:24:01Z

@Blevene This did not make it into Beta 3 in time. I expect it to be in the next beta.

jamesmason84 · 2015-02-19T22:41:38Z

I'm really excited for this feature. Did it make it into v4.0.0, which was just released?

spalger · 2015-02-20T01:16:04Z

@jamesmason84 yep! You can find in in the time picker by clicking the time filter description on the right of the nav bar.

Adding autorefresh using courier and timefilter

f6d05dd

Adding tests for refresh interval feature

f0359af

spalger reviewed Dec 12, 2014
View reviewed changes

Added more tests to refresh interval feature. Adding better error che…

d725327

…cking.

spalger mentioned this pull request Dec 15, 2014

Merge 2196 #2324

Closed

grouma added 2 commits December 15, 2014 15:09

Merge branch 'master' of https://github.com/elasticsearch/kibana into…

083b63a

… TimefilterAutoRefresh Conflicts: src/kibana/components/timepicker/timepicker.html

Prevent refresh of data when "off" refresh interval is selected

67df143

Spencer Alger added 2 commits December 16, 2014 01:15

moved segmented search into a courier fetch strategy

8ae871c

[fetch] check for #getIncompleteRequests when strategies complete the…

e6df20d

…ir requests

spalger mentioned this pull request Dec 16, 2014

Move segmented fetch to courier #2336

Closed

Spencer Alger added 4 commits December 16, 2014 02:06

[courier/fetchThese] reformatted and teased a bit

40cc3cb

[discover/segmentedFetch] disabled the tests for now

710581b

[courier/segmentedSearch] expose the #mergeResponse method

c23525a

Merge branch 'TimefilterAutoRefresh' of github.com:grouma/kibana into…

eb3d904

… segment_in_courier

[discover] update the time on each request

65e0a87

spalger assigned w33ble and unassigned spalger Dec 29, 2014

Merge branch 'master' of https://github.com/elasticsearch/kibana into…

b139243

… TimefilterAutoRefresh

w33ble assigned spalger and unassigned w33ble Dec 29, 2014

Spencer Alger added 2 commits December 29, 2014 16:43

[promises] ensure that Promise.map doesn't throw

844d381

[courier/docSource] use courier/fetch to fake responses to requests

a65b547

spalger assigned w33ble and simianhacker and unassigned spalger and w33ble Dec 29, 2014

Spencer Alger added 4 commits December 29, 2014 19:11

[courier/fetch/segmented] first emit is for first segment with rows, …

0cb8c09

…only emit segments with rows

[disocver] rely on guaranteed event order

e83dc4f

[discover] only overlay before first results

ba32f62

[discover] vertically center the throbber

8af2ffd

spalger mentioned this pull request Dec 30, 2014

Sorting is a bit random in discover #2483

Closed

spalger pushed a commit that referenced this pull request Dec 30, 2014

Merge pull request #2196 from grouma/TimefilterAutoRefresh

1e348de

Timefilter Auto Refresh - Closes "Support for auto-refresh #1845"

spalger merged commit 1e348de into elastic:master Dec 30, 2014

spalger mentioned this pull request Jan 4, 2015

Fix spy #2514

Merged

spalger mentioned this pull request Nov 4, 2015

Bug with fetching a single source #5270

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Timefilter Auto Refresh - Closes "Support for auto-refresh #1845" #2196

Timefilter Auto Refresh - Closes "Support for auto-refresh #1845" #2196

grouma commented Dec 9, 2014

rashidkpc commented Dec 9, 2014

grouma commented Dec 9, 2014

grouma commented Dec 9, 2014

rashidkpc commented Dec 11, 2014

grouma commented Dec 11, 2014

spalger Dec 12, 2014

grouma Dec 13, 2014

spalger commented Dec 12, 2014

grouma commented Dec 15, 2014

spalger commented Dec 15, 2014

grouma commented Dec 15, 2014

w33ble commented Dec 15, 2014

grouma commented Dec 15, 2014

spalger commented Dec 15, 2014

grouma commented Dec 16, 2014

spalger commented Dec 16, 2014

simianhacker commented Dec 30, 2014

spalger commented Dec 30, 2014

spalger commented Dec 30, 2014

grouma commented Jan 1, 2015

w33ble commented Jan 5, 2015

Blevene commented Feb 5, 2015

grouma commented Feb 5, 2015

jamesmason84 commented Feb 19, 2015

spalger commented Feb 20, 2015

Timefilter Auto Refresh - Closes "Support for auto-refresh #1845" #2196

Timefilter Auto Refresh - Closes "Support for auto-refresh #1845" #2196

Conversation

grouma commented Dec 9, 2014

rashidkpc commented Dec 9, 2014

grouma commented Dec 9, 2014

grouma commented Dec 9, 2014

rashidkpc commented Dec 11, 2014

grouma commented Dec 11, 2014

spalger Dec 12, 2014

Choose a reason for hiding this comment

grouma Dec 13, 2014

Choose a reason for hiding this comment

spalger commented Dec 12, 2014

grouma commented Dec 15, 2014

spalger commented Dec 15, 2014

grouma commented Dec 15, 2014

w33ble commented Dec 15, 2014

grouma commented Dec 15, 2014

spalger commented Dec 15, 2014

grouma commented Dec 16, 2014

spalger commented Dec 16, 2014

simianhacker commented Dec 30, 2014

spalger commented Dec 30, 2014

spalger commented Dec 30, 2014

grouma commented Jan 1, 2015

w33ble commented Jan 5, 2015

Blevene commented Feb 5, 2015

grouma commented Feb 5, 2015

jamesmason84 commented Feb 19, 2015

spalger commented Feb 20, 2015