-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timefilter Auto Refresh - Closes "Support for auto-refresh #1845" #2196
Merged
Merged
Changes from 2 commits
Commits
Show all changes
95 commits
Select commit
Hold shift + click to select a range
f6d05dd
Adding autorefresh using courier and timefilter
grouma f0359af
Adding tests for refresh interval feature
grouma d725327
Added more tests to refresh interval feature. Adding better error che…
grouma 083b63a
Merge branch 'master' of https://github.com/elasticsearch/kibana into…
grouma 67df143
Prevent refresh of data when "off" refresh interval is selected
grouma 8ae871c
moved segmented search into a courier fetch strategy
e6df20d
[fetch] check for #getIncompleteRequests when strategies complete the…
40cc3cb
[courier/fetchThese] reformatted and teased a bit
710581b
[discover/segmentedFetch] disabled the tests for now
c23525a
[courier/segmentedSearch] expose the #mergeResponse method
eb3d904
Merge branch 'TimefilterAutoRefresh' of github.com:grouma/kibana into…
90aed85
Merge pull request #1 from spenceralger/segment_in_courier
grouma 11aa394
Simplifying the refresh UI
grouma 776a1b8
[timepicker] slight modification to navbar css
2c8c48b
Merge pull request #2 from spenceralger/TimefilterAutoRefresh
grouma b5debf2
[discover] improve style of discover vis overlay that has been busted…
5a2a605
Merge branch 'TimefilterAutoRefresh' of github.com:grouma/kibana into…
09c3fd1
Refresh interval is now saved in session storage. Corresponding tests…
grouma 1a15a78
Fixing issues with refresh interval session storage. Removing unecess…
grouma dab0dc4
Merge branch 'configure_private' into TimefilterAutoRefresh
5215fd1
[courier/fetch/segmented] proxy the strategy method to SegmentedState
735d455
[courier/segmentedState] ensure that events will always emit in order
7162728
[courier/fetch] broke fetchThese into more manageable pieces
2e14260
[courier/fetch/segmented] added tests and fixed discovered bugs
2f3ef3c
Merge branch 'master' into TimefilterAutoRefresh
f137a65
Merge pull request #3 from spenceralger/TimefilterAutoRefresh
grouma e8b23c8
[notifier] stop the courier on fatal errors
e3b50fb
[timepicker] fix invalid html entity
ad025a2
Merge branch 'master' into TimefilterAutoRefresh
03f0e51
[timepicker] HTMLPrettify'd that thang
32be3c3
[courier] warn when refresh interval is too damn high
be7e9f2
[courier] restart the looper on #fetch(), don't trigger. Fetch direct…
64b9d7f
Cleaning up refresh interval options.
grouma 8a8526d
[courier] refactored request queue, allowing requests to be restarted
61537df
[courier/segmentedRequest] only init state at request time
0a07e71
[courier/looper] track loop completion and rejected promises
bea6d12
[courier] shorter request class names +1
f5bfcfe
[courier] restart in progress requests on fetch()
59db253
[events] update tests to use callbacks
08f2136
[events] always emit in the same order that emit was called
5875b37
[errors] default to no error for RequestFailure
5a3e3a9
[courier/requestQueue] simplify pending request logic
0260b26
[courier] only call fetch, not both fetch and looper
288ffe0
[courier/fetch] tease and simplify fetch, added restartable requests
34d7b70
Merge branch 'TimefilterAutoRefresh' of github.com:grouma/kibana into…
dd66001
[courier/looper] allow preventing fetch on restart
3b7ad9c
[timepicker] fix bag merge
ca7f216
[timepicker] readability improvments
7d90ce4
Merge branch 'master' into TimefilterAutoRefresh
12bc607
[courier/fetch] remove fetch method for removed segmented strategy
2496036
[courier/source] update method used to cancel requests
a1977a3
[courier] fix moved method
103297a
[courier/fetch] use ABORT to id canceled es request
7fcab33
[courier/fetch] added comments
668b5cf
[kibana] remove debug code
1fdf755
[courier/fetch/segmented] infer the totalSize from the flattened sear…
591a3a3
Merge pull request #4 from spenceralger/TimefilterAutoRefresh
grouma 5f49c28
Merge branch 'master' of https://github.com/elasticsearch/kibana into…
a96f260
[courier/looper] prevent looper from starting until told to
45b9f00
[courier/DocRequest] cleanup
f530db2
[indexPatterns] get as many ids as possible
dcabba8
[tests] reanable all and clear storage before running
6cd1ab2
[docTitle] fixed test
2684435
[timepicker] updated tests for new style
859f56a
[courier] properly abort requests on close
e186ed1
[courier/fetch] always ignore unavailable indices
be22579
[courier/fetch] allow requests to filter the errors that cause rejection
e2c9ae5
[courier] deleted tests for now
ffe9252
[courier] move fatal callback into Courier to magically fix issue (th…
fd7f75c
Merge branch 'master' of https://github.com/elasticsearch/kibana into…
e432638
Merge pull request #5 from spenceralger/TimefilterAutoRefresh
grouma 34d42a1
[courier/looper] convert to kbn Class style
c86e32b
[courier/looper] only fetch inactive requests
ee7ab28
[courier/looper] schedule once the previous run is complete
b030caa
[discover] restart the courier.searchLooper when fetch is complete
577d92f
remove unused deps
5a84841
Merge branch 'master' of https://github.com/elasticsearch/kibana into…
5c4dec6
[courier/fetch] reset the searchLooper after fetching
424e5ee
use courier.fetch() rather than .fetchQueued()
3f0bcf2
remove extra reassignment
cacb033
removed debugging assignment
98a2cbc
Merge pull request #6 from spenceralger/TimefilterAutoRefresh
grouma 6cb601f
apply 6e7cf2d
c016970
implement 92d206c
084dbda
[courier/looper] manage the loopers timer a bit more closely, fixes h…
c779d01
[courier/fetch/segmented] don't call the initFn until start
17a0e5a
[discover] always catch errors that are returned
65e0a87
[discover] update the time on each request
b139243
Merge branch 'master' of https://github.com/elasticsearch/kibana into…
844d381
[promises] ensure that Promise.map doesn't throw
a65b547
[courier/docSource] use courier/fetch to fake responses to requests
0cb8c09
[courier/fetch/segmented] first emit is for first segment with rows, …
e83dc4f
[disocver] rely on guaranteed event order
ba32f62
[discover] only overlay before first results
8af2ffd
[discover] vertically center the throbber
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
<kbn-timepicker | ||
from="timefilter.time.from" | ||
to="timefilter.time.to" | ||
mode="timefilter.time.mode"> | ||
mode="timefilter.time.mode" | ||
interval="timefilter.refreshInterval"> | ||
</kbn-timepicker> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ | |
<!-- Full navbar --> | ||
<div collapse="!showCollapsed" class="navbar-collapse" id="kibana-primary-navbar"> | ||
<ul class="nav navbar-nav"> | ||
<li ng-repeat="app in apps.inOrder | filter:{show: true}" ng-class="{active: activeApp === app}"> | ||
<li ng-repeat="app in apps.inOrder" ng-class="{active: activeApp === app}"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will fix. |
||
<a ng-href="#{{app.lastPath}}" bo-text="app.name"></a> | ||
</li> | ||
</ul> | ||
|
@@ -30,6 +30,7 @@ | |
</li> | ||
<li ng-if="setupComplete" ng-show="timefilter.enabled" class="navbar-timepicker-display"> | ||
<a ng-click="toggleTimepicker()"> | ||
Refresh: {{timefilter.refreshInterval.display}} - Filter: | ||
<pretty-duration from="timefilter.time.from" to="timefilter.time.to"></pretty-duration> | ||
| ||
<i class="fa fa-clock-o"></i> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I realize what this check accomplishes, I'd prefer if this was a falsy check, or a check that
refreshInterval
is infact a valid interval, rather than checking if it is one of the many things it might be.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a check to ensure the refreshInterval contains a numeric value property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good plan. What do you think about implementing the default value here? if
$scope.timefilter.refreshInterval
isn't a valid interval then assign the default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Defaulting it to 0 will turn off the auto refresh.