[Code]should update search results if search options change #41232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangQianliang
added
v8.0.0
Team:Code
release_note:skip
|
Pinging @elastic/code |
💔 Build Failed |
|
retest |
💔 Build Failed |
mw-ding
approved these changes
Jul 16, 2019
|
btw, what does the |
mw-ding
reviewed
Jul 16, 2019
| @@ -146,3 +151,35 @@ function* handleReposSearchForScope(action: Action<RepositorySearchPayload>) { | |||
| export function* watchRepoScopeSearch() { | |||
| yield takeEvery(searchReposForScope, handleReposSearchForScope); | |||
| } | |||
|
|
|||
| function* handleSaveSearchOptions(action: Action<SearchOptions>) { | |||
There was a problem hiding this comment.
one question here is that what do we need to create new logics for handling the search scope updates? I mean, we should already have some logic handling these cases, why not adding changes in there?
There was a problem hiding this comment.
https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/code/public/components/search_bar/search_bar.tsx#L36 do you think it make sense to merge all the logics to handle the search scope changes together?
💚 Build Succeeded |
💔 Build Failed |
|
retest |
💔 Build Failed |
mw-ding
approved these changes
Jul 17, 2019
|
please rebase to fix the ci |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
WangQianliang
pushed a commit
that referenced
this pull request
Jul 22, 2019
WangQianliang
pushed a commit
that referenced
this pull request
Jul 22, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 22, 2019
…b-panel-for-stopping-jobs * 'master' of github.com:elastic/kibana: (58 commits) [DOCS] Timelion cleanup (elastic#41381) [Docs] Add simple phrase highlighting to Logs UI (elastic#41610) [Maps] Rename modules for clarity (elastic#41608) [Monitoring] Metricbeat migration net new user experience (elastic#39832) [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607) [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576) [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565) update dark mode tsvb test (elastic#41618) [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774) Reactify Top Nav Menu (kbn_top_nav) (elastic#40262) fix(code/frontend): should update search results if search options change (elastic#41232) Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581) [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621) [Canvas] Updates esdocs default count to 1000 (elastic#41604) [Uptime] Fix duration chart for Safari (elastic#41619) [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528) docs: lowercase app (elastic#41612) [Code] Update git repository update frequency (elastic#41541) Remove language=json on code blocks due to performance hit (elastic#41540) [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
should update search results if search options change
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately