[Maps][File upload] Fix lag issue on add of es doc layer for uploaded data #41540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
|
slowed down caused because EuiCodeBlock renders all of the DOM elements even those that are off screen. Need to implement elastic/eui#1208 to fix this performance problem and keep json styling enabled. |
💔 Build Failed |
|
retest |
nreese
approved these changes
Jul 19, 2019
💔 Build Failed |
|
retest |
💔 Build Failed |
kindsun
added
the
release_note:skip
💚 Build Succeeded |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Jul 19, 2019
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Jul 19, 2019
kindsun
pushed a commit
that referenced
this pull request
Jul 19, 2019
kindsun
pushed a commit
that referenced
this pull request
Jul 19, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 22, 2019
…b-panel-for-stopping-jobs * 'master' of github.com:elastic/kibana: (58 commits) [DOCS] Timelion cleanup (elastic#41381) [Docs] Add simple phrase highlighting to Logs UI (elastic#41610) [Maps] Rename modules for clarity (elastic#41608) [Monitoring] Metricbeat migration net new user experience (elastic#39832) [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607) [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576) [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565) update dark mode tsvb test (elastic#41618) [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774) Reactify Top Nav Menu (kbn_top_nav) (elastic#40262) fix(code/frontend): should update search results if search options change (elastic#41232) Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581) [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621) [Canvas] Updates esdocs default count to 1000 (elastic#41604) [Uptime] Fix duration chart for Safari (elastic#41619) [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528) docs: lowercase app (elastic#41612) [Code] Update git repository update frequency (elastic#41541) Remove language=json on code blocks due to performance hit (elastic#41540) [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41493.
EuiCodeBlockhas an option to specify the language. The language was correctly specificied asjsonby #39429, however app performance deteriorated considerably as json responses grew in size. Language highlighting is performed by the highlight.js lib. It's not clear at this point if this is a json-specific issue or just a general optimization opportunity for the highlight lib.Moving forward, we might consider whether or not these lengthy json responses are useful or not and consider revising, but for now it seems like the best option is to just remove the json highlighting and retain the unhighlighted responses as it was before.
Using the dataset below, before removing
language="json"on bothEuiCodeBlocks, the step between index completion and adding the layer took ~29 seconds. After removing these attributes, it took ~1-2 secondsne_10m_populated_places.json.tar.gz