Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] make grid rectangles the default symbolization for geo grid source #50169

Merged
merged 11 commits into from
Nov 13, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 11, 2019

fixes #49976

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔲 🔳

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
@nreese nreese requested a review from gchaps November 11, 2019 19:05
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is really helpful. I'm wondering if we can cut down on the text a bit:

Use aggregated layers with document layers to show aggregated views when the map shows larger
amounts of the globe and individual documents when the map shows smaller regions.

In the following example, the Grid aggregation layer is only visible when the map is at zoom levels 0 through 5. The Documents layer is only visible when the map is at zoom levels 4 through 24. 
See the Getting started tutorial for more details on configuring the layers.

@nreese
Copy link
Contributor Author

nreese commented Nov 13, 2019

I'm wondering if we can cut down on the text a bit

Merged simplified text

@nreese nreese requested a review from gchaps November 13, 2019 17:45
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor nit. I would combine the "See the Getting Started" with the previous paragraph.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Nov 13, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit 9212eb2 into elastic:master Nov 13, 2019
nreese added a commit to nreese/kibana that referenced this pull request Nov 13, 2019
…urce (elastic#50169)

* [Maps] default grid aggregation source rendering to grid

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* add animated gif and text describing the animation

* clean up text

* simply text

* combine link to getting started with previous paragraph
nreese added a commit that referenced this pull request Nov 13, 2019
…urce (#50169) (#50527)

* [Maps] default grid aggregation source rendering to grid

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* add animated gif and text describing the animation

* clean up text

* simply text

* combine link to getting started with previous paragraph
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 14, 2019
…urce (elastic#50169)

* [Maps] default grid aggregation source rendering to grid

* Update docs/maps/maps-aggregations.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* add animated gif and text describing the animation

* clean up text

* simply text

* combine link to getting started with previous paragraph
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits)
  [Rollup] Fix for clone job workflow (elastic#50501)
  Empty message "No data available" for Labels and User metadata sections missing (elastic#49846)
  [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315)
  Remove react references from core `Notifications` apis (elastic#49573)
  Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic
  [Metrics UI] Calculate interval based on the dataset's period (elastic#50194)
  chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610)
  [Telemetry] change of optin status telemetry (elastic#50158)
  [SIEM][Detection Engine] REST API Additions (elastic#50514)
  [DOCS] Removes dashboard-only mode doc (elastic#50441)
  [Filters] Fix operator overflowing out popover (elastic#50030)
  Change telemetry optIn to default to true (elastic#50490)
  [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169)
  Allow registered applications to hide Kibana chrome (elastic#49795)
  Upgrade EUI to v14.9.0 (elastic#49678)
  [Metrics UI] Convert layouts to use React components (elastic#49134)
  [Search service] Add support for ES request preference (elastic#49424)
  [Newsfeed/Lint] fix chained fn lint (elastic#50515)
  [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166)
  [SIEM] Events viewer fixes (elastic#50175)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Consider making grid rectangles the default for grid agg layer
4 participants