Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Duration by Country map doesn't take transactionName into account #50315

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

cauemarcondes
Copy link
Contributor

closes #50097

Transaction overview request.
Screenshot 2019-11-12 at 15 26 07

Transaction details page
Screenshot 2019-11-12 at 15 26 17

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@smith
Copy link
Contributor

smith commented Nov 12, 2019

@elasticmachine test this please

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the additional cleanup too.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogupte
Copy link
Contributor

ogupte commented Nov 13, 2019

is this a blocker for 7.5? if not we should change the label to 7.6

@cauemarcondes
Copy link
Contributor Author

@ogupte I'm merging this today and backporting to 7.5.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cauemarcondes
Copy link
Contributor Author

jenkins, retest this please

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cauemarcondes cauemarcondes merged commit 353619b into elastic:master Nov 14, 2019
@cauemarcondes cauemarcondes deleted the apm-98400 branch November 14, 2019 07:47
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Nov 14, 2019
…ount (elastic#50315)

* filtering country map by transaction name

* filtering country map by transaction name

* filtering country map by transaction name
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Nov 14, 2019
…ount (elastic#50315)

* filtering country map by transaction name

* filtering country map by transaction name

* filtering country map by transaction name
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits)
  [Rollup] Fix for clone job workflow (elastic#50501)
  Empty message "No data available" for Labels and User metadata sections missing (elastic#49846)
  [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315)
  Remove react references from core `Notifications` apis (elastic#49573)
  Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic
  [Metrics UI] Calculate interval based on the dataset's period (elastic#50194)
  chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610)
  [Telemetry] change of optin status telemetry (elastic#50158)
  [SIEM][Detection Engine] REST API Additions (elastic#50514)
  [DOCS] Removes dashboard-only mode doc (elastic#50441)
  [Filters] Fix operator overflowing out popover (elastic#50030)
  Change telemetry optIn to default to true (elastic#50490)
  [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169)
  Allow registered applications to hide Kibana chrome (elastic#49795)
  Upgrade EUI to v14.9.0 (elastic#49678)
  [Metrics UI] Convert layouts to use React components (elastic#49134)
  [Search service] Add support for ES request preference (elastic#49424)
  [Newsfeed/Lint] fix chained fn lint (elastic#50515)
  [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166)
  [SIEM] Events viewer fixes (elastic#50175)
  ...
cauemarcondes added a commit that referenced this pull request Nov 14, 2019
…ount (#50315) (#50618)

* filtering country map by transaction name

* filtering country map by transaction name

* filtering country map by transaction name
cauemarcondes added a commit that referenced this pull request Nov 14, 2019
…ount (#50315) (#50617)

* filtering country map by transaction name

* filtering country map by transaction name

* filtering country map by transaction name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Duration by Country map doesn't take transactionName into account
4 participants