Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ecommerce percentages in sample data #54200

Merged
merged 1 commit into from
Jan 8, 2020
Merged

fix ecommerce percentages in sample data #54200

merged 1 commit into from
Jan 8, 2020

Conversation

timductive
Copy link
Member

Summary

closes #47831
Fixes percentage calculation in ecommerce sample data.
Screen Shot 2020-01-07 at 4 02 56 PM
Screen Shot 2020-01-07 at 4 02 45 PM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

@timductive timductive added bug Fixes for quality problems that affect the customer experience review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.6.0 labels Jan 7, 2020
@timductive timductive requested a review from a team as a code owner January 7, 2020 22:06
@timductive timductive self-assigned this Jan 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

ryankeairns
ryankeairns approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaded up, percentages look good!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@timductive timductive merged commit 3b5a90b into elastic:master Jan 8, 2020
@timductive timductive mentioned this pull request Jan 8, 2020
Merged
timductive added a commit to timductive/kibana that referenced this pull request Jan 8, 2020
@timductive
fix ecommerce percentages in sample data (elastic#54200)
2309bb1
timductive added a commit that referenced this pull request Jan 8, 2020
@timductive
fix ecommerce percentages in sample data (#54200) (#54254)
d1f3296
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 8, 2020
@gmmorris
Merge branch 'master' into task-manager/schema-config
f5ec90c 
* master:
  Reorganize structure of component render to avoid errors. (elastic#54251)
  [DOCS] consolidate telemetry settings to core (elastic#52634)
  Add file upload to telemetry integration tests (elastic#53539)
  filters are back (elastic#54218)
  Add explanation of path.data to contribution guide (elastic#54235)
  fix ecommerce percentages in sample data (elastic#54200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees

@timductive timductive

Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eCommerce demo percentages are not between 0 and 100%
4 participants
@timductive @elasticmachine @kibanamachine @ryankeairns