Add explanation of path.data to contribution guide #54235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
v8.0.0
release_note:skip
💚 Build SucceededTo update your PR or re-run it, just comment with: |
stacey-gammon
approved these changes
Jan 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 8, 2020
* master: Reorganize structure of component render to avoid errors. (elastic#54251) [DOCS] consolidate telemetry settings to core (elastic#52634) Add file upload to telemetry integration tests (elastic#53539) filters are back (elastic#54218) Add explanation of path.data to contribution guide (elastic#54235) fix ecommerce percentages in sample data (elastic#54200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explanation for the usage of the
path.dataparameter to the contribution guide. We currently only used this a bit later for remote clusters, but never explained it. Since new developers often come across that issue, wanted to highlight it into a separate paragraph.