[ML] Fixes permissions checks for data visualizer create job links #55431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
walterra
reviewed
Jan 22, 2020
| @@ -131,7 +133,10 @@ export const Page: FC = () => { | |||
| const defaults = getDefaultPageState(); | |||
|
|
|||
| const [showActionsPanel] = useState( | |||
There was a problem hiding this comment.
I think we can remove useState here since the value gets never updated and just do const showActionsPanel = ...
There was a problem hiding this comment.
Done in 901a166
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 22, 2020
…lastic#55431) * [ML] Fixes permissions checks for data visualizer create job links * [ML] Edits to permissions check following review * [ML] Revert unintentional additions
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 22, 2020
…lastic#55431) * [ML] Fixes permissions checks for data visualizer create job links * [ML] Edits to permissions check following review * [ML] Revert unintentional additions
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 22, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: [Watcher] Add support for additional watch action statuses (elastic#55092) [ML] Fix entity controls update. (elastic#55524) [ML] Fixing ML's watcher integration (elastic#55439) [ML] Fixes permissions checks for data visualizer create job links (elastic#55431) [SearchProfiler] Move out of legacy (elastic#55331) # Conflicts: # x-pack/plugins/watcher/server/models/action_status/action_status.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the check used to determine whether or not to show the 'Create job' links in the index-based data visualizer.
As well as checking for a full license and a time-based index, checks are now also made that the user has the
canCreateJobprivilege and there are ML nodes available. If any of these checks return false, the side panel containing the links to the advanced wizard and any modules is hidden:For maintainers
Fixes #55178