-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate queue types being used by Beats #59850
Aggregate queue types being used by Beats #59850
Conversation
4c54413
to
527b2fd
Compare
How can I make these stats show up? I'm seeing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I haven't tested it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types for BeatsBaseStats
need to include the new queue
entries
@afharo I'm not familiar with Typescript so hopefully I did the right thing in 2076d80. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the filterPath to include the new queue path: https://github.com/elastic/kibana/pull/59850/files#diff-ed4dfe3e626069cc7ad7e5b1a85d18bbR346
Thanks @chrisronline for catching this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI!
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Aggregate queue types being used by Beats * Making tests pass again * Updating fixture + tests for queue type * Adding queue field to BeatsBaseStats type * Add undefined guard * Adding queue field to source fields list * Fixing type error
* Aggregate queue types being used by Beats * Making tests pass again * Updating fixture + tests for queue type * Adding queue field to BeatsBaseStats type * Add undefined guard * Adding queue field to source fields list * Fixing type error
* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)
Summary
This PR teaches the telemetry collection code in Kibana to count the various queue types (mem or spool) used by Beats in a cluster.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
This was checked for breaking API changes and was labeled appropriately