[Logs UI] Show navigation bar while loading source configuration #59997
Conversation
weltenwort
added
release_note:enhancement
v8.0.0
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
| @@ -146,6 +146,27 @@ export const useLogAnalysisModule = <JobType extends string>({ | |||
| sourceId, | |||
| ]); | |||
|
|
|||
| useEffect(() => { | |||
| dispatchModuleStatus({ | |||
There was a problem hiding this comment.
I'm curious of how all of this connects together.
What does this effect do exactly to allow showing the tabs earlier in the loading process?
There was a problem hiding this comment.
Previously, the module status reducer only used the source configuration it was initialized with to determine whether the job configuration is up-to-date. This meant that the source configuration had to be known before the provider was mounted.
Since this PR moves the loading state further down the hierarchy, the source configuration is now loaded in parallel to the job configuration. This tries to make sure that the reducer correctly evaluates the job configuration's currentness if the source configuration arrives asynchronously.
Does that make sense?
…tic#59997) This moves the navigation bar and the source configuration loading indicator such that the bar is immediately visible and usable even before the source configuration has finished loading. closes elastic#56728
* master: [Alerting] extend Alert Type with names/descriptions of action variables (elastic#59756) [Ingest] Fix data source creation and double system data source (elastic#60069) Add button to view full service map (elastic#59394) unskip tests for code coverage (elastic#59725) [Ingest] Add Fleet & EPM features (elastic#59376) [Logs UI] Show navigation bar while loading source configurati… (elastic#59997) [Endpoint] ERT-82 Alerts search bar (elastic#59702) Aggregate queue types being used by Beats (elastic#59850) skip flaky suite (elastic#59541) Convert Timeline to TypeScript (elastic#59966) Make context.core required argument to context providers (elastic#59996)
Backports the following commits to 7.x: - [Logs UI] Show navigation bar while loading source configurati… (#59997)
Summary
This moves the navigation bar and the source configuration loading indicator such that the bar is immediately visible and usable even before the source configuration has finished loading.
closes #56728
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportUnit or functional tests were updated or added to match the most common scenarios