Update app arch CODEOWNERS items. #60396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
review
chore
v8.0.0
Team:AppArch
release_note:skip
lukeelmers
commented
Mar 17, 2020
.github/CODEOWNERS
Outdated
| /src/plugins/bfetch/ @elastic/kibana-app-arch | ||
| /src/plugins/data/ @elastic/kibana-app-arch | ||
| /src/plugins/embeddable/ @elastic/kibana-app-arch | ||
| /src/plugins/expressions/ @elastic/kibana-app-arch | ||
| /src/plugins/inspector/ @elastic/kibana-app-arch | ||
| /src/plugins/kibana_react/ @elastic/kibana-app-arch | ||
| /src/plugins/kibana_react/public/code_editor @elastic/canvas |
There was a problem hiding this comment.
Since the last matching pattern takes precedence in CODEOWNERS files, any subsequent patterns listed after kibana_react should match and ping the relevant team instead of app arch.
There was a problem hiding this comment.
I noticed I had a typo in the handle here & just pushed a correction to this PR.
- /src/plugins/kibana_react/public/code_editor @elastic/canvas
+ /src/plugins/kibana_react/public/code_editor @elastic/kibana-canvas
streamich
approved these changes
Mar 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 18, 2020
* master: [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) Update ingest management team handle (elastic#60457) [IM] Use EuiCodeBlock to render index mapping (elastic#60420) Add additional safeguards for data source wizard step 2 (elastic#60426) [kbn/pm] don't fail when plugins are outside repo (elastic#60164) upgrade react-use (elastic#60427) Remove link to old settings (elastic#60326) Update app arch CODEOWNERS items. (elastic#60396) [ML] Fixing custom urls to dashboards (elastic#60355) Update the ems-client dependency to 7.7.0 (elastic#59936)
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
lukeelmers
added
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our recent @elastic/kibana-app-arch team discussion, this PR adds @elastic/kibana-canvas as owners for the
code_editordirectory inkibana_react.While app arch still owns the overall contract of
kibana_react(andkibana_utils) plugins, we may occasionally run into situations like this where it makes sense to have a few specific subdirectories maintained by other teams.This PR also cleans up a few other app arch items: