-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #66185 #66186
fix #66185 #66186
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
7a2f2af
to
31be22b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what triggers this bug? We have an existing test for importing saved objects with an index pattern that doesn't exist, so I assume this is slightly different. Can we add a test case to https://github.com/elastic/kibana/blob/afca33b5206e1389af18da81a91682904f2b4c79/test/functional/apps/management/_import_objects.js
this.patternCache, | ||
this.fieldsFetcher | ||
this.apiClient, | ||
this.patternCache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we improve the types for patternCache
(both the class property and constructor argument uses any
) to prevent this from happening in the future?
@rudolf: the test is different as it skips the import of the document with missing index pattern and this bug happens when you actually choose to import that document with a different index (selecting one of the indexes in dropdown) |
2b406b9
to
4d59a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Can we backport this to include it in 7.7.1 and 7.8.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Firefox and works as expected. LGTM
@elasticmachine merge upstream |
# Conflicts: # src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305) [security_solution] enable react-hooks/exhaustive-deps (elastic#68470) Closes elastic#66867 by adding missing, requried API params (elastic#68465) [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865) [Logs UI] View in context tweaks (elastic#67777) Kibana developer examples landing page (elastic#67049) Bump decompress package version (elastic#68386) fix elastic#66185 (elastic#66186) Bump pdfmake package version (elastic#68395) Unskip embeddables/adding_children suite (elastic#68111) Add embed mode options in the Share UI (elastic#58435) Adding key to avoid react warning (elastic#68491)
Summary
Fixes bug with importing legacy json files without matching index patterns
Fixes #66185
Fixes #64280
Checklist
Delete any items that are not applicable to this PR.
[ ] Unit or functional testscreated issue to add test here: [test coverage] add test for legacy saved object import with missing index pattern #66204